Add Deprecator.skip_warning? ability to silence deprecators on tests#2956
Merged
thdaraujo merged 15 commits intofaker-ruby:mainfrom Jul 9, 2024
Merged
Add Deprecator.skip_warning? ability to silence deprecators on tests#2956thdaraujo merged 15 commits intofaker-ruby:mainfrom
Deprecator.skip_warning? ability to silence deprecators on tests#2956thdaraujo merged 15 commits intofaker-ruby:mainfrom
Conversation
stefannibrasil
approved these changes
Jun 11, 2024
Contributor
stefannibrasil
left a comment
stefannibrasil
left a comment
There was a problem hiding this comment.
This LGTM, thank you!
@thdaraujo could you give a review when you can? Thanks!
thdaraujo
reviewed
Jun 13, 2024
thdaraujo
reviewed
Jun 13, 2024
Contributor
Author
|
@thdaraujo Thanks, I'll take a look at your suggestion and also figure out why you're seeing the deprecation message. |
Contributor
Author
|
@thdaraujo @stefannibrasil I have fixed the issue and have updated your requested changes. |
Contributor
Author
|
@stefannibrasil Reordered it, I misunderstood earlier |
This variable is not needed anymore.
thdaraujo
reviewed
Jul 9, 2024
thdaraujo
changed the title
skip_warning ability to silence deprecators on tests
thdaraujo
changed the title
skip_warning ability to silence deprecators on testsskip_warning ability to silence deprecators on tests
thdaraujo
changed the title
skip_warning ability to silence deprecators on testsDeprecator.skip_warning? ability to silence deprecators on tests
thdaraujo
approved these changes
Jul 9, 2024
Contributor
thdaraujo
left a comment
thdaraujo
left a comment
There was a problem hiding this comment.
perfect, thanks for working on this! @keshavbiswa
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
Fixes: #2948
This Pull Request has been created because We want the ability to silence output warnings for Deprecated Generators in tests.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator or locale: