Username splits names by space and doesn't regex match them#2950
Merged
stefannibrasil merged 9 commits intofaker-ruby:mainfrom May 28, 2024
Merged
Username splits names by space and doesn't regex match them#2950stefannibrasil merged 9 commits intofaker-ruby:mainfrom
stefannibrasil merged 9 commits intofaker-ruby:mainfrom
Conversation
Contributor
|
hi @keshavbiswa thanks! I think we want to drop the character and make it part of the last name. I added a comment here #2943 (comment) |
alextaujenis
suggested changes
May 8, 2024
Contributor
Author
|
So ultimately, I am stripping username with apostrophe |
alextaujenis
suggested changes
May 9, 2024
Contributor
Author
|
Could I get a re-review on this 🙂 ? @alextaujenis @stefannibrasil |
alextaujenis
approved these changes
May 16, 2024
Contributor
Author
|
@stefannibrasil Can we merge this? |
stefannibrasil
approved these changes
May 28, 2024
Contributor
stefannibrasil
left a comment
stefannibrasil
left a comment
There was a problem hiding this comment.
thank you @keshavbiswa looking much better now without splitting the apostrophe from the last name 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because Username doesn't behave well with Apostrophe names such as "Alexis O'Connell".
Since we're matching them by word, it breaks them into 3 parts "alexis", "o", "connell". (Not sure if this is correct behaviour as we don't have English names 😅 )
This causes problem testing emails as we get the following list of permutations:
This PR breaks names by Spaces and doesn't ignore '.
Additional information
This PR also fixes: #2943
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator or locale: