fix polish bban_pattern#2887
Merged
stefannibrasil merged 1 commit intofaker-ruby:mainfrom Jan 12, 2024
Merged
Conversation
stefannibrasil
approved these changes
Jan 12, 2024
Contributor
stefannibrasil
left a comment
stefannibrasil
left a comment
There was a problem hiding this comment.
Thank you!
One note: it would be nice if the commit contained more details about why this was wrong and why the change is now correct. For example: "Polish IBAN numbers don't accept characters, only digits". That way, we keep our git history helpful for the next developers changing/reviewing this code.
Contributor
|
The failure is related to a minitest version. Gonna fix it in a follow up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because of invalid polish bban_pattern
Additional information
Source
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]