Conversation
Add benchmark rake task for evaluating time execution. Fixes Co-authored-by: Rubens Fernandes <[email protected]>
thdaraujo
left a comment
thdaraujo
left a comment
There was a problem hiding this comment.
Excellent contribution, thanks for working on this!
This is a great first step to help us improve the performance of the gem. 🙏
Thanks @salochara and @okaydokay97 for working on this!
I just left one suggestion, let me know what you think.
- Build all_methods outside the benchmark since we don't want to measure that.
salochara
force-pushed
the
feature/add-benchmark
branch
from
f531b8e to
3fb283e
Compare
|
Hi @thdaraujo ! This is looking good! Probably we can create an "issue" here on GH have a simple draft on next steps, things to do. Would love to keep on contributing ! All the best! 🙏🏼 |
stefannibrasil
left a comment
stefannibrasil
left a comment
There was a problem hiding this comment.
Thank you both! I left a small suggestion.
In terms of the next steps, I added a comment in the issue to keep things centralized there.
- Avoid calling the same object twice
|
Done! ✅ Awesome... I'll have a look at it whenever I get a chance. |
stefannibrasil
left a comment
stefannibrasil
left a comment
There was a problem hiding this comment.
Thank you for working on this! Excited to see how we can improve faker's performance :)
3 participants
Motivation / Background
Fixes #2851
In this PR, @okaydokay97 and I are adding a rake task to run a benchmark on every Faker generator!
Here's a screenshot of the results:
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]