Add zh-CN translations for Bank names#2840
Merged
thdaraujo merged 2 commits intofaker-ruby:mainfrom Oct 28, 2023
guxiaobai:main
Merged
Add zh-CN translations for Bank names#2840thdaraujo merged 2 commits intofaker-ruby:mainfrom guxiaobai:main
zh-CN translations for Bank names#2840thdaraujo merged 2 commits intofaker-ruby:mainfrom
guxiaobai:main
Conversation
thdaraujo
requested changes
Oct 24, 2023
Contributor
thdaraujo
left a comment
thdaraujo
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
Please change the syntax to use dashes instead of an array, take a look at this doc:
https://github.com/faker-ruby/faker/blob/main/CONTRIBUTING.md#yaml-files
lib/locales/zh-CN/bank.yml
Outdated
| zh-CN: | ||
| faker: | ||
| bank: | ||
| name: ['工商银行', '交通银行', '招商银行', '民生银行', '浦发银行', '兴业银行', '光大银行', '广发银行', '平安银行', '建设银行', '邮政储蓄银行'] |
Contributor
There was a problem hiding this comment.
we prefer to use the dash syntax for lists of elements, see documentation.
Contributor
Author
There was a problem hiding this comment.
Thank you. I've repaired it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
This Pull Request has been created because [REPLACE ME]
Additional information
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator: