Add Japanese for Games Touhou#2829
Add Japanese for Games Touhou#2829stefannibrasil merged 1 commit intofaker-ruby:mainfrom shiroemons:add-japanese-for-games-touhou
Conversation
stefannibrasil
left a comment
stefannibrasil
left a comment
There was a problem hiding this comment.
Hi @shiroemons thank you for your contribution! Could you limit the number of lines in the file? It's really large. We don't need to include everything, maybe just 50 would be a good maximum limit?
Thank you!
|
Hi, @stefannibrasil thank you for the feedback! While I couldn't reduce the file to 50 lines, I've managed to trim it down by about 80%. I hope this makes it more manageable. |
|
Thank you @shiroemons yes, that is so much more manageable. One final thing- I translated them and there are some words that I wanted to ask to be removed: "murder", "bullet". I understand they are part of the game vocabulary but I want to avoid merging words that can instigate/mention violence. thank you! |
|
Thank you for your feedback! The terms "murder" and "bullet" have been removed from the codebase. Could you please confirm if there are any other instances where the term "bullet" is translated? Thank you! |
stefannibrasil
left a comment
stefannibrasil
left a comment
There was a problem hiding this comment.
All good, thank you @shiroemons 🇯🇵
2 participants
Motivation / Background
This Pull Request has been created because there was no Japanese support for Games Touhou.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]