Fix typo in lib/locales/README.md#2812
Merged
thdaraujo merged 10 commits intofaker-ruby:mainfrom Aug 19, 2023
Merged
Conversation
thdaraujo
requested changes
Aug 17, 2023
Contributor
thdaraujo
left a comment
thdaraujo
left a comment
There was a problem hiding this comment.
Thanks for fixing the typo!
The gemfile changes are unnecessary though.
thdaraujo
changed the title
Reverted Gemfile back to original.
Corrected whitespace difference in original.
BelaBartok39
commented
Aug 18, 2023
Contributor
Author
BelaBartok39
left a comment
BelaBartok39
left a comment
There was a problem hiding this comment.
Removed Gemfile from accidently including on pull request.
added 3 commits
August 18, 2023 14:48
…-readme-typos # Conflicts: # Gemfile.lock
thdaraujo
reviewed
Aug 19, 2023
thdaraujo
changed the title
lib/locales/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation / Background
My motivation is to get better at best practices by contributing small changes to my favorite teams.
Additional information
Fixed a very small typo in the locales/README.md file. Line 23.
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator: