Remove unneeded require in lib/faker.rb#2558
Merged
stefannibrasil merged 1 commit intofaker-ruby:masterfrom Sep 23, 2022
dmarcoux:i18n
Merged
Remove unneeded require in lib/faker.rb#2558stefannibrasil merged 1 commit intofaker-ruby:masterfrom dmarcoux:i18n
stefannibrasil merged 1 commit intofaker-ruby:masterfrom
dmarcoux:i18n
Conversation
The version of the dependency i18n has to be at least 1.8.11, so this `require` can be safely removed.
Contributor
Author
thdaraujo
requested changes
Sep 12, 2022
Contributor
|
thank you @dmarcoux it looks like |
Contributor
stefannibrasil
left a comment
stefannibrasil
left a comment
There was a problem hiding this comment.
Looks good for now. Thanks @dmarcoux 💯
sudeeptarlekar
pushed a commit
to sudeeptarlekar/faker
that referenced
this pull request
Oct 7, 2022
The version of the dependency i18n has to be at least 1.8.11, so this `require` can be safely removed.
Contributor
Author
|
Thank you for handling this, I was away for some time, so I couldn't act on your comments. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The version of the dependency i18n has to be at least 1.8.11, so this
requirecan be safely removed.Fixes Issue #2524