Merged
Conversation
stefannibrasil
force-pushed
the
update-simplecov-gem
branch
from
f39a540 to
a34f5f3
Compare
Zeragamba
approved these changes
Sep 6, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Issue #2525
Previously, we had a workaround regarding upgrading Simplecov. But the issue has been solved and this workaround can be removed.
According to Simplecov's documentation, we need to configure the configure the JSON formatter CI consumption or for reporting to external services.
The code coverage report was successfully generated after upgrading simplecov's version:
Other Information
I also removed a comment regarding travis secret. It's not strictly related to this PR, but cleans up our CI a bit.