Skip to content

Conversation

@matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer requested a review from a team as a code owner November 13, 2025 16:09
@netlify
Copy link

netlify bot commented Nov 13, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit b1589ee
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6930993a2acbbb00083b9f61
😎 Deploy Preview https://deploy-preview-3656.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@matthewmayer matthewmayer changed the title feat(locale) add da states (regions) feat(locale): add da states (regions) Nov 13, 2025
@xDivisionByZerox xDivisionByZerox added c: locale Permutes locale definitions m: location Something is referring to the location module labels Nov 13, 2025
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Nov 13, 2025
xDivisionByZerox

This comment was marked as duplicate.

Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

We could also take a look at Municipality (Kommuner) for county in the future.

@xDivisionByZerox xDivisionByZerox modified the milestones: vAnytime, v10.x Nov 13, 2025
@xDivisionByZerox xDivisionByZerox added the c: feature Request for new feature label Dec 3, 2025
@codecov
Copy link

codecov bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (a5812bc) to head (b1589ee).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3656   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2994     2995    +1     
  Lines      236234   236243    +9     
  Branches      940      940           
=======================================
+ Hits       236177   236186    +9     
  Misses         57       57           
Files with missing lines Coverage Δ
src/locales/da/location/index.ts 100.00% <100.00%> (ø)
src/locales/da/location/state.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Dec 3, 2025
Merged via the queue into faker-js:next with commit 78c892b Dec 3, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: feature Request for new feature c: locale Permutes locale definitions m: location Something is referring to the location module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants