Skip to content

Conversation

@PenguinMan98
Copy link
Contributor

@PenguinMan98 PenguinMan98 commented Oct 16, 2025

Addresses issue:
#3635

@PenguinMan98 PenguinMan98 requested a review from a team as a code owner October 16, 2025 22:26
@netlify
Copy link

netlify bot commented Oct 16, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 0499f14
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/690feb291e661600089b5443
😎 Deploy Preview https://deploy-preview-3636.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@PenguinMan98 PenguinMan98 changed the title Updated spelling Mercielago to Murcielago fix: Updated spelling Mercielago to Murcielago Oct 16, 2025
@matthewmayer matthewmayer changed the title fix: Updated spelling Mercielago to Murcielago fix(vehicle): Updated spelling Mercielago to Murcielago Oct 17, 2025
matthewmayer
matthewmayer previously approved these changes Oct 17, 2025
Copy link
Contributor

@matthewmayer matthewmayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codecov
Copy link

codecov bot commented Oct 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (f45077c) to head (0499f14).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3636   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2993     2993           
  Lines      236268   236268           
  Branches      932      932           
=======================================
  Hits       236215   236215           
  Misses         53       53           
Files with missing lines Coverage Δ
src/locales/en/vehicle/model.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Shinigami92
Shinigami92 previously approved these changes Nov 7, 2025
@Shinigami92 Shinigami92 added c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module labels Nov 7, 2025
@xDivisionByZerox xDivisionByZerox dismissed stale reviews from Shinigami92, matthewmayer, and themself via 0499f14 November 9, 2025 01:15
Copy link
Member

@xDivisionByZerox xDivisionByZerox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code generation was failing due to local file sorting not being respected. I've updated the file accordingly. I saw that other team members already approved and will count their approval for the following merge.

@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Nov 9, 2025
Merged via the queue into faker-js:next with commit bfb1bdb Nov 9, 2025
23 checks passed
@xDivisionByZerox xDivisionByZerox linked an issue Nov 9, 2025 that may be closed by this pull request
@xDivisionByZerox xDivisionByZerox added this to the v10.x milestone Nov 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: vehicle Something is referring to the vehicle module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix the spelling to Murcielago

5 participants