Skip to content

feat(locale): add ku_kmr_latin locale #3629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
matthewmayer merged 8 commits into from
Nov 6, 2025
Merged

feat(locale): add ku_kmr_latin locale #3629

matthewmayer merged 8 commits into from
Nov 6, 2025

Conversation

@mazyar-kawa02
Copy link
Contributor

@mazyar-kawa02 mazyar-kawa02 commented Oct 4, 2025

No description provided.

@mazyar-kawa02 mazyar-kawa02 requested a review from a team as a code owner October 4, 2025 16:46
@netlify
Copy link

netlify bot commented Oct 4, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ba738ee
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/690c8eeafa6a390008a92675
😎 Deploy Preview https://deploy-preview-3629.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@mazyar-kawa02 mazyar-kawa02 mentioned this pull request Oct 4, 2025
Closed
@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature c: locale Permutes locale definitions p: 1-normal Nothing urgent labels Oct 4, 2025
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Oct 4, 2025
@xDivisionByZerox xDivisionByZerox added m: color Something is referring to the color module m: person Something is referring to the person module labels Oct 4, 2025
xDivisionByZerox
xDivisionByZerox reviewed Oct 4, 2025
View reviewed changes
@xDivisionByZerox xDivisionByZerox mentioned this pull request Oct 4, 2025
Merged
matthewmayer
matthewmayer requested changes Oct 5, 2025
View reviewed changes
@mazyar-kawa02
Copy link
Contributor Author

mazyar-kawa02 commented Oct 5, 2025 •
edited
Loading

@xDivisionByZerox @matthewmayer now I’ve made all the changes you asked for.

matthewmayer
matthewmayer reviewed Oct 6, 2025
View reviewed changes
@matthewmayer
Copy link
Contributor

matthewmayer commented Oct 7, 2025

please also re-run pnpm run test:update-snapshots to fix snapshot tests

@mazyar-kawa02
Copy link
Contributor Author

mazyar-kawa02 commented Oct 7, 2025

@matthewmayer Okay now everything is done

@codecov
Copy link

codecov bot commented Oct 7, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (3dbcbe1) to head (ba738ee).
⚠️ Report is 2 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff            @@
##             next    #3629    +/-   ##
========================================
  Coverage   99.97%   99.97%            
========================================
  Files        2981     2993    +12     
  Lines      235922   236268   +346     
  Branches      932      932            
========================================
+ Hits       235869   236215   +346     
  Misses         53       53
Files with missing lines Coverage Δ
src/locale/index.ts 100.00% <100.00%> (ø)
src/locale/ku_kmr_latin.ts 100.00% <100.00%> (ø)
src/locales/index.ts 100.00% <100.00%> (ø)
src/locales/ku_kmr_latin/color/human.ts 100.00% <100.00%> (ø)
src/locales/ku_kmr_latin/color/index.ts 100.00% <100.00%> (ø)
src/locales/ku_kmr_latin/index.ts 100.00% <100.00%> (ø)
src/locales/ku_kmr_latin/metadata.ts 100.00% <100.00%> (ø)
src/locales/ku_kmr_latin/person/first_name.ts 100.00% <100.00%> (ø)
src/locales/ku_kmr_latin/person/index.ts 100.00% <100.00%> (ø)
src/locales/ku_kmr_latin/person/job_type.ts 100.00% <100.00%> (ø)
... and 4 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mazyar-kawa02
Copy link
Contributor Author

mazyar-kawa02 commented Oct 13, 2025

@matthewmayer @xDivisionByZerox Could you please check now and let me know if there are any issues?

@matthewmayer
Copy link
Contributor

matthewmayer commented Oct 13, 2025

Nothing required on your end at this point. The one remaining test failure Is unrelated to this issue.

xDivisionByZerox
xDivisionByZerox reviewed Oct 13, 2025
View reviewed changes
matthewmayer
matthewmayer previously approved these changes Oct 17, 2025
View reviewed changes
@mazyar-kawa02
Copy link
Contributor Author

mazyar-kawa02 commented Oct 17, 2025

@matthewmayer Thanks a lot for the approval! 🙌
I’m really excited about this addition — many Kurdish developers will be happy to see Kurdish support in this package.
When do you plan to merge it?

@matthewmayer
Copy link
Contributor

matthewmayer commented Oct 17, 2025

It is pretty normal that it can take between a few days and a few weeks to merge PRs, and then a few more weeks to make it into a release. I know you are excited to show this off but please be patient, the maintainers are all volunteers and have to divide our time between lots of things.

@mazyar-kawa02
Copy link
Contributor Author

mazyar-kawa02 commented Oct 17, 2025

It is pretty normal that it can take between a few days and a few weeks to merge PRs, and then a few more weeks to make it into a release. I know you are excited to show this off but please be patient, the maintainers are all volunteers and have to divide our time between lots of things.

Okay, It's not a problem thanks

Shinigami92
Shinigami92 previously approved these changes Oct 17, 2025
View reviewed changes
@Shinigami92 Shinigami92 enabled auto-merge November 5, 2025 12:34
@matthewmayer matthewmayer dismissed stale reviews from Shinigami92 and themself via ba738ee November 6, 2025 12:04
@matthewmayer
Merge branch 'next' into mazyar-kawa02/next
ba738ee 
# Conflicts:
#	docs/guide/localization.md
#	test/__snapshots__/locale-data.spec.ts.snap
@Shinigami92 Shinigami92 added this pull request to the merge queue Nov 6, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 6, 2025
@matthewmayer matthewmayer added this pull request to the merge queue Nov 6, 2025
Merged via the queue into faker-js:next with commit 247f42d Nov 6, 2025
36 of 37 checks passed
@mazyar-kawa02
Copy link
Contributor Author

mazyar-kawa02 commented Nov 7, 2025

Thanks for reviewing and merging my changes! Really appreciate it @matthewmayer @Shinigami92 @xDivisionByZerox

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xDivisionByZerox xDivisionByZerox xDivisionByZerox left review comments

@matthewmayer matthewmayer matthewmayer approved these changes

@Shinigami92 Shinigami92 Shinigami92 approved these changes

+1 more reviewer

@Manethpak Manethpak Manethpak left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mazyar-kawa02 mazyar-kawa02

Labels

c: feature Request for new feature c: locale Permutes locale definitions m: color Something is referring to the color module m: person Something is referring to the person module p: 1-normal Nothing urgent

Projects

None yet

Milestone

vAnytime

Development

Successfully merging this pull request may close these issues.

5 participants

@mazyar-kawa02 @matthewmayer @Shinigami92 @Manethpak @xDivisionByZerox