Thank you for your PR @jylep.

I see in the PR description that your intend was to add "top-level administrative" for Norway. I can see in the linked sources that this administrative level is called "county" in Norway. So I can see why you would put them into the "county.ts" file.

Please take a look at the descriptions of the county and state property in the location definition:

• faker/src/definitions/location.ts

  Lines 55 to 58 in b547045

  	/**
  	* The names of this country's states, or other first-level administrative areas.
  	*/
  	state: string[];

• faker/src/definitions/location.ts

  Lines 65 to 68 in b547045

  	/**
  	* The names of counties, or other second-level administrative areas, inside the country's states.
  	*/
  	county: string[];

As you can see state represents the first-level administrative areas while county represents the second-level administrative areas. This has sadly been the case for quite some time due to the historic nature of the project heavily defaulting to the US state for structuring locale data sets.

After reading on the administrative divisions of Norway I would suggest putting the Norwegen "counties" (fylker) into Fakers "state" (first-level) property, while the Norwegen "municipalities" (kommune) would match Fakers "county" (second-level) property.

I can see that this might cause confusion due to the naming collision between Fakers naming definition and the real words application of these words. But, I'd say it is much better in the long run, to stay consistent and honor the specification of a fields when adding locale data to it. I can see the names of these entries change in the future to a more generic term, as we had this exact problem multiple times now.

Please tell me your opinion on the matter and thank you again for taking the initiative and time to making Faker better for anyone by providing these locale data.