Skip to content

Add Kurdish Kurmanji (Latin and Arabic) locale support #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mazyar-kawa02 wants to merge 1 commit into from
Closed

Add Kurdish Kurmanji (Latin and Arabic) locale support #3615

mazyar-kawa02 wants to merge 1 commit into from

Conversation

@mazyar-kawa02
Copy link
Contributor

@mazyar-kawa02 mazyar-kawa02 commented Sep 22, 2025

  • Implemented person-related data including first names, last names, prefixes, and name patterns for both ku_kmr_arab and ku_kmr_latin.
  • Added vehicle-related data including fuel types, manufacturers, models, and vehicle types for both ku_kmr_arab and ku_kmr_latin.
  • Introduced color definitions for human colors in ku_kmr_latin.
  • Created date definitions including months and weekdays for ku_kmr_latin.
  • Established cell phone number formats for ku_kmr_latin.
  • Developed location data including city names, building numbers, street addresses, and state names for ku_kmr_latin.
  • Added lorem ipsum word definitions for ku_kmr_latin.
  • Generated metadata for the Kurdish Kurmanji language in ku_kmr_latin.

@mazyar-kawa02
Add Kurdish Kurmanji (Latin and Arabic) locale support
3bdc5e5 
- Implemented person-related data including first names, last names, prefixes, and name patterns for both ku_kmr_arab and ku_kmr_latin.
- Added vehicle-related data including fuel types, manufacturers, models, and vehicle types for both ku_kmr_arab and ku_kmr_latin.
- Introduced color definitions for human colors in ku_kmr_latin.
- Created date definitions including months and weekdays for ku_kmr_latin.
- Established cell phone number formats for ku_kmr_latin.
- Developed location data including city names, building numbers, street addresses, and state names for ku_kmr_latin.
- Added lorem ipsum word definitions for ku_kmr_latin.
- Generated metadata for the Kurdish Kurmanji language in ku_kmr_latin.
@mazyar-kawa02 mazyar-kawa02 requested a review from a team as a code owner September 22, 2025 10:25
@netlify
Copy link

netlify bot commented Sep 22, 2025 •
edited
Loading

❌ Deploy Preview for fakerjs failed.

Built without sensitive environment variables

Name Link
🔨 Latest commit 3bdc5e5
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/68d124023eab260008ed35f3

@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Sep 22, 2025

@mazyar-kawa02 Thank you for contributing to Faker.
As by our contribution guidelines, I want to request you to keep this PR to a single module. This keeps the review process straight for all participants. You are welcome to open separate PRs for the modules you choose to dismiss in this PR

@xDivisionByZerox xDivisionByZerox added c: feature Request for new feature c: locale Permutes locale definitions labels Sep 22, 2025
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Sep 22, 2025
@xDivisionByZerox xDivisionByZerox added the p: 1-normal Nothing urgent label Sep 22, 2025
@matthewmayer
Copy link
Contributor

matthewmayer commented Sep 23, 2025

We should probably resolve our discussion on #3441 about the most suitable language codes.

We should avoid too much bikeshedding. Picking the ideal language code is important but not so important to block adding the data.

@mazyar-kawa02
Copy link
Contributor Author

mazyar-kawa02 commented Sep 23, 2025

Now what is needed to be done from my side? also is my PR will be merged ?

@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Sep 24, 2025

We should probably resolve our discussion on #3441 about the most suitable language codes.

We should avoid too much bikeshedding. Picking the ideal language code is important but not so important to block adding the data.

@matthewmayer I agree with you. I'll try to get some focus onto the other PR.

Now what is needed to be done from my side? also is my PR will be merged ?

@mazyar-kawa02 I was not aware of the PR mentioned by matthew. PR #3441 should probably be merged first, as it provides the foundation to the locale data sets you are trying to add. After #3441 is merged, you can update your branch and then provide PRs that add locale data. I'd suggest that I'll ping you again when the time for that has come.

@mazyar-kawa02
Copy link
Contributor Author

mazyar-kawa02 commented Sep 25, 2025

We should probably resolve our discussion on #3441 about the most suitable language codes.
We should avoid too much bikeshedding. Picking the ideal language code is important but not so important to block adding the data.

@matthewmayer I agree with you. I'll try to get some focus onto the other PR.

Now what is needed to be done from my side? also is my PR will be merged ?

@mazyar-kawa02 I was not aware of the PR mentioned by matthew. PR #3441 should probably be merged first, as it provides the foundation to the locale data sets you are trying to add. After #3441 is merged, you can update your branch and then provide PRs that add locale data. I'd suggest that I'll ping you again when the time for that has come.

@xDivisionByZerox I reviewed PR #3441, and it only includes Kurdish Sorani. It also uses placeholder text (lorem ipsum) instead of proper first and last names.
In comparison, my PR includes Kurdish Kurmanji (both Latin and Arabic scripts) as well as Kurdish Sorani (Central Kurdish).

@matthewmayer matthewmayer mentioned this pull request Oct 4, 2025
Merged
@matthewmayer
Copy link
Contributor

matthewmayer commented Oct 4, 2025 •
edited
Loading

Now what is needed to be done from my side? also is my PR will be merged ?

The other Kurdish PR has now been merged.

Please refer to this comment for the approved codes to use in metadata #3441 (review)

We would like to break this PR into smaller pieces to make it easier to review

Can you make a new PR with just the new ku_kmr_latin locale and metadata, and one or two simple modules included (eg person and color).

Once that is approved you can follow up with additional PRs for other modules and ku_kmr_arab

@mazyar-kawa02
Copy link
Contributor Author

mazyar-kawa02 commented Oct 4, 2025

Now what is needed to be done from my side? also is my PR will be merged ?

The other Kurdish PR has now been merged.

Please refer to this comment for the approved codes to use in metadata #3441 (review)

We would like to break this PR into smaller pieces to make it easier to review

Can you make a new PR with just the new ku_kmr_latin locale and metadata, and one or two simple modules included (eg person and color).

Once that is approved you can follow up with additional PRs for other modules and ku_kmr_arab

Okay, I created a new PR: #3629.
I’ve added only ku_kmr_latin for now — once you review it, I’ll add the other modules and ku_kmr_arab.

@xDivisionByZerox
Copy link
Member

xDivisionByZerox commented Oct 4, 2025

I’ve added only ku_kmr_latin for now — once you review it, I’ll add the other modules and ku_kmr_arab.

Thank you. Your efforts are greatly appreciated. 🫶 👏

@matthewmayer matthewmayer added the do NOT merge yet Do not merge this PR into the target branch yet label Oct 17, 2025
@matthewmayer
Copy link
Contributor

matthewmayer commented Nov 6, 2025

#3629 was now merged!

If you'd like to follow up with additional PRs for other modules for ku_kmr_latin or start a ku_kmr_arab PR now please feel free to do so!

@matthewmayer
Copy link
Contributor

matthewmayer commented Nov 6, 2025

Note closing this PR for now. Please open additional PRs as needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@mazyar-kawa02 mazyar-kawa02

Labels

c: feature Request for new feature c: locale Permutes locale definitions do NOT merge yet Do not merge this PR into the target branch yet p: 1-normal Nothing urgent

Projects

None yet

Milestone

vAnytime

Development

Successfully merging this pull request may close these issues.

3 participants

@mazyar-kawa02 @xDivisionByZerox @matthewmayer