Skip to content

refactor(image): mark loremflickr as deprecated, use only picsum photos in url() #3610

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xDivisionByZerox merged 5 commits into from
Sep 8, 2025
Merged

refactor(image): mark loremflickr as deprecated, use only picsum photos in url() #3610

xDivisionByZerox merged 5 commits into from
Sep 8, 2025

Conversation

@matthewmayer
Copy link
Contributor

@matthewmayer matthewmayer commented Sep 7, 2025

fix #3443

@matthewmayer matthewmayer requested a review from a team as a code owner September 7, 2025 15:07
@netlify
Copy link

netlify bot commented Sep 7, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 3657c6d
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/68be9beb77a2c900080f75ed
😎 Deploy Preview https://deploy-preview-3610.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@matthewmayer matthewmayer self-assigned this Sep 7, 2025
@matthewmayer matthewmayer marked this pull request as draft September 7, 2025 15:29
Shinigami92
Shinigami92 reviewed Sep 7, 2025
View reviewed changes
Shinigami92
Shinigami92 reviewed Sep 8, 2025
View reviewed changes
@codecov
Copy link

codecov bot commented Sep 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (454ddf4) to head (3657c6d).
⚠️ Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3610   +/-   ##
=======================================
  Coverage   99.96%   99.97%           
=======================================
  Files        2894     2894           
  Lines      222385   222390    +5     
  Branches      929      932    +3     
=======================================
+ Hits       222318   222337   +19     
+ Misses         67       53   -14
Files with missing lines Coverage Δ
src/modules/image/index.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewmayer matthewmayer marked this pull request as ready for review September 8, 2025 09:16
@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent m: image Something is referring to the image module deprecation A deprecation was made in the PR labels Sep 8, 2025
@xDivisionByZerox xDivisionByZerox added this to the v10.x milestone Sep 8, 2025
@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Sep 8, 2025
Merged via the queue into next with commit aa79846 Sep 8, 2025
26 checks passed
@xDivisionByZerox xDivisionByZerox deleted the deprecate-loremflickr branch September 8, 2025 10:02
@chrisbbreuer chrisbbreuer mentioned this pull request Oct 15, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@matthewmayer matthewmayer

Labels

deprecation A deprecation was made in the PR m: image Something is referring to the image module p: 1-normal Nothing urgent

Projects

None yet

Milestone

v10.x

Development

Successfully merging this pull request may close these issues.

LoremFlickr down for good?

4 participants

@matthewmayer @Shinigami92 @xDivisionByZerox