Skip to content

Conversation

@xDivisionByZerox
Copy link
Member

@xDivisionByZerox xDivisionByZerox commented Aug 7, 2025

Description

This PR extends the v10 migration guide by providing additional information for CJS users. The requirements where found while updating our playground to @faker-js/[email protected] in faker-js/playground#50.

Additionally, the usage guide was update to better reflect the new requirements for configuring TypeScript when using Faker.

See:

@xDivisionByZerox xDivisionByZerox added this to the v10.0 milestone Aug 7, 2025
@xDivisionByZerox xDivisionByZerox requested a review from a team August 7, 2025 14:06
@xDivisionByZerox xDivisionByZerox self-assigned this Aug 7, 2025
@xDivisionByZerox xDivisionByZerox requested a review from a team as a code owner August 7, 2025 14:06
@xDivisionByZerox xDivisionByZerox added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Aug 7, 2025
@netlify
Copy link

netlify bot commented Aug 7, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit cb915bb
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/689f1b7c4acb4400085a819d
😎 Deploy Preview https://deploy-preview-3587.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Aug 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.96%. Comparing base (9783d95) to head (cb915bb).

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3587   +/-   ##
=======================================
  Coverage   99.96%   99.96%           
=======================================
  Files        2894     2894           
  Lines      222385   222385           
  Branches      931      930    -1     
=======================================
  Hits       222318   222318           
  Misses         67       67           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Shinigami92
Shinigami92 previously approved these changes Aug 7, 2025
@xDivisionByZerox xDivisionByZerox added this pull request to the merge queue Aug 16, 2025
Merged via the queue into next with commit b16dd9a Aug 16, 2025
23 checks passed
@xDivisionByZerox xDivisionByZerox deleted the docs/playground-findings-faker-v10 branch August 16, 2025 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: docs Improvements or additions to documentation p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants