✅ Deploy Preview for fakerjs ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	74b3082
🔍 Latest deploy log	https://app.netlify.com/projects/fakerjs/deploys/68f23c1be5078a0008cee3e7
😎 Deploy Preview	https://deploy-preview-3564.fakerjs.dev
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Thanks!

Note for the initial PR for adding a language we recommend adding one module only (e.g. person as you have done here). Please don't add additional modules to this PR until it has been reviewed and approved. Once it's approved you can follow up with additional PRs to add further modules.

Note also we are soon releasing v10, a major release, so we likely won't merge this imminently. It is more likely to make it into a v10.1 release in a few weeks.

You are currently missing the first_name and last_name files.

@matthewmayer I know they were missing, this is why PR was set to draft. Thank you for the notice though.

I have added them now.

I tried to run pnpm run preflight but ran into errors

I am asking for some assistance on how to approach this issue, thank you.

I tried to run pnpm run preflight but ran into errors

I am asking for some assistance on how to approach this issue, thank you.

I'll run the CI and so we can identify if it's a real error or just a local one to your environment

I assume it has todo something with that suffix is null in this PR
Can't check right now immediately cause I'm on mobile

@Shinigami92 I have updated file src/locales/sl_SI/person/suffix.ts with array of values instead of null and problem is solved.

Ready for review. Thank you.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.97%. Comparing base (f81abc7) to head (74b3082).
⚠️ Report is 5 commits behind head on next.

@@           Coverage Diff            @@
##             next    #3564    +/-   ##
========================================
  Coverage   99.97%   99.97%            
========================================
  Files        2906     2926    +20     
  Lines      222684   223520   +836     
  Branches      931      932     +1     
========================================
+ Hits       222631   223467   +836     
  Misses         53       53            

For future reference, If you don't want to provide suffixes for a locale, thats fine (not all languages have them) but then you need to add the locale to line 61 of test/all-functional.spec.ts to allow the test to pass

@matthewmayer can this be also approved by faker-js/maintainers?

We will get to this in due course, it has not been forgotten.

@matthewmayer there are some errors.

@ZigaVukcevicDev this is now merged! if youd like to follow up with additional PRs for any other modules for sl-SI, please now feel free to do so.

@matthewmayer thank you! I am on it.