Skip to content

Conversation

@Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Jun 15, 2025

While configuring projects at company work, I copied over some huge parts of Faker's structure into the company projects. While doing that, I found out that some parts are not working as intended or outdated.

This PR fixes some issues with out current eslint.config.ts

@Shinigami92 Shinigami92 added this to the vAnytime milestone Jun 15, 2025
@Shinigami92 Shinigami92 self-assigned this Jun 15, 2025
@Shinigami92 Shinigami92 added the c: infra Changes to our infrastructure or project setup label Jun 15, 2025
@netlify
Copy link

netlify bot commented Jun 15, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 2b578aa
🔍 Latest deploy log https://app.netlify.com/projects/fakerjs/deploys/6853eebc50c62b00080cae82
😎 Deploy Preview https://deploy-preview-3530.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@codecov
Copy link

codecov bot commented Jun 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (b357ea0) to head (2b578aa).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #3530   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2880     2880           
  Lines      220510   220510           
  Branches      952      952           
=======================================
  Hits       220457   220457           
  Misses         53       53           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Shinigami92 Shinigami92 mentioned this pull request Jun 15, 2025
1 task
@Shinigami92 Shinigami92 marked this pull request as ready for review June 15, 2025 08:13
@Shinigami92 Shinigami92 requested a review from a team as a code owner June 15, 2025 08:13
@Shinigami92 Shinigami92 requested a review from a team June 15, 2025 08:13
@xDivisionByZerox
Copy link
Member

Only one comment. The rest looks fine to me. 👍

@Shinigami92 Shinigami92 force-pushed the chore-update-lint-config branch from 568f948 to a15226a Compare June 15, 2025 13:27
@Shinigami92 Shinigami92 requested a review from a team June 16, 2025 21:31
@xDivisionByZerox
Copy link
Member

Since this PR is Infrastructure related, I'd say we can merge this without a second review before the usual 7 day limit. Dependency PR are handled in a similar manner.

@Shinigami92
Copy link
Member Author

I'm fine with that

@xDivisionByZerox xDivisionByZerox merged commit ca58b0c into next Jun 19, 2025
23 checks passed
@xDivisionByZerox xDivisionByZerox deleted the chore-update-lint-config branch June 19, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: infra Changes to our infrastructure or project setup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants