Skip to content

fix(locale): correct Japanese country names #3510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
xDivisionByZerox merged 3 commits into from
May 13, 2025
Merged

fix(locale): correct Japanese country names #3510

xDivisionByZerox merged 3 commits into from
May 13, 2025

Conversation

@matsueushi
Copy link
Contributor

@matsueushi matsueushi commented May 11, 2025

Reviewed and corrected country names in Japanese.

  • Removed old/obsolete country names.
  • Fixed spelling mistakes.
  • Unified country names that were split into two parts.
  • Removed regions such as Scotland and Wales that are not independent countries.

@matsueushi matsueushi requested a review from a team as a code owner May 11, 2025 12:17
@netlify
Copy link

netlify bot commented May 11, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit bc9bc4e
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/68235806b8e37c0008c78e49
😎 Deploy Preview https://deploy-preview-3510.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented May 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (c15da8e) to head (bc9bc4e).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@            Coverage Diff             @@
##             next    #3510      +/-   ##
==========================================
- Coverage   99.97%   99.97%   -0.01%     
==========================================
  Files        2880     2880              
  Lines      220507   220503       -4     
  Branches      951      951              
==========================================
- Hits       220454   220448       -6     
- Misses         53       55       +2
Files with missing lines Coverage Δ
src/locales/ja/location/country.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xDivisionByZerox xDivisionByZerox added p: 1-normal Nothing urgent c: locale Permutes locale definitions m: location Something is referring to the location module labels May 11, 2025
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone May 11, 2025
@xDivisionByZerox xDivisionByZerox modified the milestones: vAnytime, v9.x May 13, 2025
@xDivisionByZerox xDivisionByZerox merged commit 046bb81 into faker-js:next May 13, 2025
23 checks passed
@matsueushi matsueushi deleted the jpn-country branch May 14, 2025 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Shinigami92 Shinigami92 Shinigami92 approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@matsueushi matsueushi

Labels

c: locale Permutes locale definitions m: location Something is referring to the location module p: 1-normal Nothing urgent

Projects

None yet

Milestone

v9.x

Development

Successfully merging this pull request may close these issues.

3 participants

@matsueushi @Shinigami92 @xDivisionByZerox