-
-
Notifications
You must be signed in to change notification settings - Fork 1k
refactor(locale): normalize internet data #3502
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3502 +/- ##
==========================================
- Coverage 99.97% 99.97% -0.01%
==========================================
Files 2880 2880
Lines 220746 219937 -809
Branches 951 952 +1
==========================================
- Hits 220693 219884 -809
Misses 53 53
🚀 New features to boost your workflow:
|
matthewmayer
approved these changes
May 4, 2025
Shinigami92
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c: locale
Permutes locale definitions
c: refactor
PR that affects the runtime behavior, but doesn't add new features or fixes bugs
m: internet
Something is referring to the internet module
p: 1-normal
Nothing urgent
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow-on to #2265.
Normalize the entries in the
internetmodule definitions in all locales. No entries have been removed. The changes are sorting only, with the exception oflocales/base/user-agent.tswhere the comments have been restored manually.How to verify
Checkout the branch:
The branch contains two commits. One that changes the script to include the internet module being part of the normalization and one that actually updates the files.
By restoring files before the normalization happened and running it yourself, you should see the same state as this PR provides:
You should end up with the only changes being the manual comment in the
locales/base/user-agent.tsfiles, as mentioned on top.