feat(locale): Add additional Japanese last names to the locale data #3484
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3484 +/- ##
========================================
Coverage 99.97% 99.97%
========================================
Files 2880 2880
Lines 219937 220417 +480
Branches 950 949 -1
========================================
+ Hits 219884 220364 +480
Misses 53 53
🚀 New features to boost your workflow:
|
xDivisionByZerox
added
p: 1-normal
xDivisionByZerox
left a comment
xDivisionByZerox
left a comment
There was a problem hiding this comment.
For other reviewers:
I was able to verify the existente of all last names using japanese-names.info. Sadly the site has a restriction of 60 requests per hour (that's partly the reason why my review took so long). If anybody has a better source to cross verify (Japanese) names, please let me know. Before anybody says "wikipedia" - it was very tedious to get reliable results for Japanese lastnames (maybe skill issue tho).
|
As a native Japanese speaker, I reviewed the list of added last names and found no issues. All the names appear natural and appropriate as Japanese last names |
5 participants
This PR enhances the Japanese locale by adding a list of additional last names to the last_name.ts file. These updates aim to improve the diversity of the generated data for Japanese last names.