-
-
Notifications
You must be signed in to change notification settings - Fork 1k
chore(deps): update devdependencies #3456
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
a1b5099 to
f2f8dc0
Compare
|
looks like there have been some changes to isIBAN in //[email protected]
validator.isIBAN("IE06 0192 5502 8613 0093 62") //true
//[email protected]
validator.isIBAN("IE06 0192 5502 8613 0093 62") //falsethis is the fix in question https://github.com/validatorjs/validator.js/pull/2518/files |
f2f8dc0 to
3085cca
Compare
|
This PR will be automatically rebased by Renovate after we merged #3464 |
3085cca to
8e6670c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3456 +/- ##
=======================================
Coverage 99.97% 99.97%
=======================================
Files 2819 2819
Lines 217500 217500
Branches 951 951
=======================================
+ Hits 217445 217447 +2
+ Misses 55 53 -2 🚀 New features to boost your workflow:
|
8e6670c to
3dc03a0
Compare
|
I see the @types/validator package is not updated yet does it matter if these are out of sync? |
If there would be a problem, it would trigger a failure in |
Just for the future, this is only partially correct. If for example a function in the validator package would have removed a parameter, we would not be notified about this change, because the "old" types package would still be advertising the parameter. Similar, I know that v13.15.0 introduced the Is not really a bit problem, since we can just update next week (hopefully). I just wanted to clarify that it's not as easy as you stated. |
Right, it was the new functions like isISO15924, isISO31661Numeric and isULID i was wondering about as they would be useful in tests. Is there some automated way to add these types or does it need to be done by hand and added to https://github.com/DefinitelyTyped/DefinitelyTyped/pulls ? |
I understand what you mean, but I would still expect in that case that the test would fail somehow when such a parameter is not used anymore.
So @matthewmayer: yeah, first search if there is already an open PR, otherwise open a new one 🙂 |
|
@WikiRik wonder if we might be able to get your help updating the @types/validator package to support the new functions in 13.15.0? |
|
@matthewmayer thanks for the ping. I'm happy to help out! Would you like me to review a PR for new types or would you prefer that I work on a PR myself? |
I did have a go at doing it myself but to be honest it's a bit beyond my typescript abilities. So I don't want to burden you but if you already know how to I'd appreciate if you have a crack. No hurry 😀 |
|
I've opened DefinitelyTyped/DefinitelyTyped#72475 for the changes in the newest validator.js release |
This PR contains the following updates:
22.13.8->22.14.02.13.0->2.15.07.5.8->7.7.013.12.2->13.12.312.7.0->12.8.214.1.0->14.3.02.5.9->2.5.102.14.0->2.15.013.12.0->13.15.02.2.6->2.2.8Release Notes
vueuse/vueuse (@vueuse/core)
v12.8.2Compare Source
🐞 Bug Fixes
View changes on GitHub
v12.8.1Compare Source
🐞 Bug Fixes
View changes on GitHub
v12.8.0Compare Source
🚀 Features
MaybeRefandMaybeRefOrGetterin favor of Vue's native - by @ilyaliao and @antfu in https://github.com/vueuse/vueuse/issues/4636 (7432f)options.deepRefs- by @OrbisK and @antfu in https://github.com/vueuse/vueuse/issues/4591 (9afee)retriedto theautoReconnect.retries- by @9romise and @OrbisK in https://github.com/vueuse/vueuse/issues/4604 (73e6d)🐞 Bug Fixes
variablewhen initial - by @ilyaliao in https://github.com/vueuse/vueuse/issues/4641 (d680f)granted- by @Nikitatopodin and Никита Быковский in https://github.com/vueuse/vueuse/issues/4559 (f9685)View changes on GitHub
cypress-io/cypress (cypress)
v14.3.0Compare Source
Changelog: https://docs.cypress.io/app/references/changelog#14-3-0
v14.2.1Compare Source
Changelog: https://docs.cypress.io/app/references/changelog#14-2-1
v14.2.0Compare Source
Changelog: https://docs.cypress.io/app/references/changelog#14-2-0
matzkoh/prettier-plugin-packagejson (prettier-plugin-packagejson)
v2.5.10Compare Source
Bug Fixes
apostrophecms/sanitize-html (sanitize-html)
v2.15.0Compare Source
"excludeTag". Thanks to rChaoz.validatorjs/validator.js (validator)
v13.15.0Compare Source
New Features / Validators
isISO31661Numeric@RobinvanderVlietisULID@arafatknisISO15924@xDivisionByZeroxFixes, New Locales and Enhancements
isMobilePhonees-GTlocale @ignaciosuarezquilisen-GBlocale @ihmpaveluk-UAlocale @arttigerky-KGlocale @sadralieven-ZMlocale @sonikishanen-GHlocale @NanaAb-116mk-MKlocale @eshward95sq-ALlocale @nichoolaisBtcAddresssupport all address formats and testnets @madokeisIBANimproveVGregex @ST-DDTisISO4217update currency codes @cbodtorfisIdentityCardaddPKlocale @Daniyal-QureshiisEmailfix blacklist_chars @keshavlingalaisInt/isFloathandle undefined and null values @Daniyal-QureshiisPostalCodeaddCOlocale @jorgevrgsisPassportNumberexportpassportNumberLocales@derekparnellisRgbColoraddallowSpacesoption @a-h-iisUUIDrequire valid variant field and require RFC9562 UUID in versionall@broofaisURLaddmax_allowed_lengthoption @pinkieskyisEmailreject starting with double quotes @code0emperorisLicensePlateadden-SGlocale @Sabarinathan07normalizeEmailaddyandex_convert_yandexruoption @AayushGHisDatereturn false instead of Error in certain cases @pano9000isLengthadddiscreteLengthsoption @Suven-pisDatedisallow mismatching length instrictMode@sonikishanisISO6346set check digit to 0 if remainder is 10 @joelcuyisPostalCodeimproveBRlocale @ticmaisdevisEmailallow regexp inhost_whitelistandhost_blacklist@weikangchiaisIBANimproveIE/PSregex @Tarasz57vuejs/language-tools (vue-tsc)
v2.2.8Compare Source
Bug Fixes
v-modelvariable against model type"Configuration
📅 Schedule: Branch creation - "* 0-3 1 * *" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.