Skip to content

Conversation

@matsueushi
Copy link
Contributor

This PR adds support for generating finance-related test data in the Japanese locale. It includes transaction description patterns and currency data。

@matsueushi matsueushi requested a review from a team as a code owner March 29, 2025 14:07
@netlify
Copy link

netlify bot commented Mar 29, 2025

Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit aa4ecec
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67f94d7f96a2670008ac4983
😎 Deploy Preview https://deploy-preview-3449.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Mar 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (1e551c5) to head (aa4ecec).
Report is 1 commits behind head on next.

Additional details and impacted files
@@           Coverage Diff            @@
##             next    #3449    +/-   ##
========================================
  Coverage   99.97%   99.97%            
========================================
  Files        2825     2830     +5     
  Lines      217571   218533   +962     
  Branches      952      952            
========================================
+ Hits       217516   218478   +962     
  Misses         55       55            
Files with missing lines Coverage Δ
src/locales/ja/finance/account_type.ts 100.00% <100.00%> (ø)
src/locales/ja/finance/currency.ts 100.00% <100.00%> (ø)
src/locales/ja/finance/index.ts 100.00% <100.00%> (ø)
...ales/ja/finance/transaction_description_pattern.ts 100.00% <100.00%> (ø)
src/locales/ja/finance/transaction_type.ts 100.00% <100.00%> (ø)
src/locales/ja/index.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matthewmayer matthewmayer added c: locale Permutes locale definitions m: finance Something is referring to the finance module p: 1-normal Nothing urgent labels Apr 1, 2025
@xDivisionByZerox xDivisionByZerox added this to the vAnytime milestone Apr 11, 2025
@xDivisionByZerox xDivisionByZerox merged commit b2c5298 into faker-js:next Apr 11, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions m: finance Something is referring to the finance module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants