Skip to content

docs: change ejcheng #3408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ST-DDT merged 2 commits into from
Feb 27, 2025
Merged

docs: change ejcheng #3408

ST-DDT merged 2 commits into from
Feb 27, 2025

Conversation

@Shinigami92
Copy link
Member

@Shinigami92 Shinigami92 commented Feb 21, 2025

No description provided.

@Shinigami92 Shinigami92 added c: docs Improvements or additions to documentation p: 1-normal Nothing urgent labels Feb 21, 2025
@Shinigami92 Shinigami92 added this to the vAnytime milestone Feb 21, 2025
@Shinigami92 Shinigami92 self-assigned this Feb 21, 2025
@Shinigami92 Shinigami92 requested a review from a team as a code owner February 21, 2025 22:22
@Shinigami92 Shinigami92 requested a review from ejcheng February 21, 2025 22:23
@netlify
Copy link

netlify bot commented Feb 21, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 2ba0139
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67c0f1ad2cc4a500090ee784
😎 Deploy Preview https://deploy-preview-3408.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Feb 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (273b737) to head (2ba0139).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3408   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2811     2811           
  Lines      216972   216972           
  Branches      943      941    -2     
=======================================
  Hits       216917   216917           
  Misses         55       55

ejcheng
ejcheng approved these changes Feb 23, 2025
View reviewed changes
Copy link
Member

@ejcheng ejcheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not catching this earlier!

@ST-DDT ST-DDT enabled auto-merge (squash) February 27, 2025 23:13
@ST-DDT ST-DDT merged commit dce28d6 into next Feb 27, 2025
23 checks passed
@ST-DDT ST-DDT deleted the docs-change-ejcheng branch February 27, 2025 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewmayer matthewmayer matthewmayer approved these changes

@ST-DDT ST-DDT ST-DDT approved these changes

@ejcheng ejcheng ejcheng approved these changes

@xDivisionByZerox xDivisionByZerox xDivisionByZerox approved these changes

Assignees

@Shinigami92 Shinigami92

Labels

c: docs Improvements or additions to documentation p: 1-normal Nothing urgent

Projects

None yet

Milestone

vAnytime

Development

Successfully merging this pull request may close these issues.

6 participants

@Shinigami92 @matthewmayer @ST-DDT @ejcheng @xDivisionByZerox