Skip to content

refactor(internet): deprecate color method for removal #3401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ST-DDT merged 5 commits into from
Mar 6, 2025
Merged

refactor(internet): deprecate color method for removal #3401

ST-DDT merged 5 commits into from
Mar 6, 2025

Conversation

@ST-DDT
Copy link
Member

@ST-DDT ST-DDT commented Feb 13, 2025

Fixes #1959

Deprecate faker.internet.color() for removal. It's feature is sufficiently covered by the color module.

As a workaround, you can use the following method:

Popularity-Data from #3215

  • faker.internet.color: 214

Popularity-Data from GitHub Search

  • faker.internet.color: 1.1k

@ST-DDT ST-DDT added has workaround Workaround provided or linked p: 1-normal Nothing urgent c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: internet Something is referring to the internet module deprecation A deprecation was made in the PR labels Feb 13, 2025
@ST-DDT ST-DDT added this to the v9.x milestone Feb 13, 2025
@ST-DDT ST-DDT requested review from a team February 13, 2025 18:45
@ST-DDT ST-DDT self-assigned this Feb 13, 2025
@netlify
Copy link

netlify bot commented Feb 13, 2025 •
edited
Loading

✅ Deploy Preview for fakerjs ready!

Name Link
🔨 Latest commit 575458a
🔍 Latest deploy log https://app.netlify.com/sites/fakerjs/deploys/67c9d8061fe5870008a68478
😎 Deploy Preview https://deploy-preview-3401.fakerjs.dev
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Feb 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.97%. Comparing base (7b4f85a) to head (575458a).
Report is 1 commits behind head on next.

Additional details and impacted files 
@@           Coverage Diff           @@
##             next    #3401   +/-   ##
=======================================
  Coverage   99.97%   99.97%           
=======================================
  Files        2811     2811           
  Lines      217408   217414    +6     
  Branches      950      950           
=======================================
+ Hits       217355   217361    +6     
  Misses         53       53
Files with missing lines Coverage Δ
src/modules/internet/index.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ST-DDT ST-DDT merged commit 1982431 into next Mar 6, 2025
23 checks passed
@ST-DDT ST-DDT deleted the deprecate/internet/color branch March 6, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ST-DDT ST-DDT

Labels

c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs deprecation A deprecation was made in the PR has workaround Workaround provided or linked m: internet Something is referring to the internet module p: 1-normal Nothing urgent

Projects

None yet

Milestone

v9.x

Development

Successfully merging this pull request may close these issues.

faker.internet.color -> faker.color.?

2 participants

@ST-DDT