refactor(finance): deprecate maskedNumber for removal #3201
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ST-DDT
added
c: chore
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #3201 +/- ##
==========================================
- Coverage 99.96% 99.96% -0.01%
==========================================
Files 2805 2805
Lines 217129 217136 +7
Branches 976 973 -3
==========================================
+ Hits 217055 217059 +4
- Misses 74 77 +3
|
ST-DDT
changed the title
ST-DDT
added
c: refactor
Member
|
Dispite my comment in #3202, I think deprecating this method is valid:
|
xDivisionByZerox
previously approved these changes
Nov 10, 2024
matthewmayer
requested changes
Nov 10, 2024
ST-DDT
commented
Nov 10, 2024
matthewmayer
approved these changes
Nov 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2504
The masking of important information is usually implemented in the application itself, so there is no need for us to provide a method ourselves.
This is especially true, since the method has lots of options and would need even more to actually represent real masked data.
As a workaround, you can use the following:
faker.finance.creditCardNumber().replaceAll(/(?<=.{4}).(?=.{2})/g, '*')faker.finance.iban().replaceAll(/(?<=.{4})\w(?=.{2})/g, '*')Popularity-Data from #3215
faker.finance.maskedNumber: 59