Add tests for Chrome, Firefox, and Edge browsers with major version 100 #568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dattanchu
approved these changes
Feb 17, 2022
dattanchu
left a comment
dattanchu
left a comment
There was a problem hiding this comment.
Should we merge the upstream browser-test here instead?
|
My understanding is this will work until Chrome 107 - https://blog.chromium.org/2021/09/user-agent-reduction-origin-trial-and-dates.html - after that user agent string will be with reduced information and from that point forward folks should rely on Feature request for Client Hints -> #408 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This article suggested some user agent parsing libraries would have issues with Chrome, Firefox, and Edge browsers with major version 100: https://www.theverge.com/2022/2/17/22938721/chrome-firefox-edge-version-100-websites-bug-compatibility-issues-mozilla-google-microsoft
I went to each, turned on the flag in settings to force the user agent to be 100, recorded the user agent, and then tested that we still recover the browser name, version, and major version successfully. Based on this testing things look okay.