Move to check typeof for window for different envs #483
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an awesome package, and because its so small and useful you can use it in many different places, including situations where
windowwill be undefined entirely.We use this function in Bigquery Functions and in Rudderstack transformations. In both of these scenarios
windowisn't even defined so we've changed the package slightly.This PR addresses this issue and checks
typeofinstead ofwindowvariable to allow for use in different environments.