Skip to content

Conversation

@annez
Copy link
Contributor

@annez annez commented Feb 26, 2021

This is an awesome package, and because its so small and useful you can use it in many different places, including situations where window will be undefined entirely.

We use this function in Bigquery Functions and in Rudderstack transformations. In both of these scenarios window isn't even defined so we've changed the package slightly.

This PR addresses this issue and checks typeof instead of window variable to allow for use in different environments.

@faisalman faisalman changed the base branch from master to develop March 13, 2021 18:07
@faisalman faisalman merged commit 70a586d into faisalman:develop Mar 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants