FIX: Wechat Desktop for Windows compatible with new version #477
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisalman
requested changes
Mar 13, 2021
Owner
faisalman
left a comment
faisalman
left a comment
There was a problem hiding this comment.
Hi @crcong thanks for the fix, however I found that the new regex seems to be vulnerable (simply check http://redos-checker.surge.sh/), needs to be revised so I can safely merge this.. 👍
Contributor
Author
|
Hi @faisalman, you' re so kind. Thank you for your advice. I've changed the regex I wrote earlier. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the update of wechat desktop software, it is judged that the browser version information in Windows wechat desktop software has been invalid, and it needs to be compatible.