Fix dashboard news widget and add caching #223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
function_exists check needs to be moved as function not yet defined. Signed-off-by: Andy Fragen <[email protected]>
costdev
requested changes
Aug 17, 2025
Member
costdev
left a comment
costdev
left a comment
There was a problem hiding this comment.
Just one change request, otherwise looks good
inc/dashboard-widgets/namespace.php
Outdated
| $response = wp_remote_get( EVENTS_API ); | ||
| if ( is_wp_error( $response ) ) { | ||
| return $response; | ||
| $response = wp_cache_get( EVENTS_API ); |
Member
There was a problem hiding this comment.
We should use the Transient API here instead. Sites without a persistent cache won't see a benefit when this isn't likely to get hit many times in one page load.
Contributor
Author
There was a problem hiding this comment.
Actually, even without a persistent cache WP_Cache_Object lasts for a page load. It's subsequent page loads that are affected.
Member
There was a problem hiding this comment.
That's what I mean - the non-persistent cache only lasts for a page load, so using wp_cache_* wouldn't give any benefit for those sites, so the Transient API is better here
Signed-off-by: Andy Fragen <[email protected]>
costdev
approved these changes
Aug 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
function_existscheck needs to be moved as function not yet defined and so the entireinc\dashboard-widgets/namespace.php::bootstrap()is skipped.This also adds caching to the
wp_remote_get()call.Fixes #222