Split compat.php into php-polyfill.php and wp-polyfill.php #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Fragen <[email protected]> remove PHPCS exclude Signed-off-by: Andy Fragen <[email protected]> require polyfills Signed-off-by: Andy Fragen <[email protected]> lint polyfills Signed-off-by: Andy Fragen <[email protected]> oops Signed-off-by: Andy Fragen <[email protected]> sorta place in order Signed-off-by: Andy Fragen <[email protected]>
Contributor
Author
|
Coding standards error is not in any of these files and is fixed in #156 |
costdev
requested changes
Jul 17, 2025
costdev
requested changes
Jul 17, 2025
Ipstenu
previously requested changes
Jul 17, 2025
Signed-off-by: Andy Fragen <[email protected]> Co-authored-by: Colin Stewart <[email protected]> Signed-off-by: Andy Fragen <[email protected]>
Signed-off-by: Andy Fragen <[email protected]>
Signed-off-by: Andy Fragen <[email protected]>
costdev
requested changes
Jul 17, 2025
Contributor
Author
|
I'll create another PR to fix the coding standards issues from https://github.com/fairpm/fair-plugin/actions/runs/16355570099 |
Signed-off-by: Andy Fragen <[email protected]>
costdev
approved these changes
Jul 17, 2025
Signed-off-by: Andy Fragen <[email protected]>
Contributor
Author
|
@Ipstenu can you re-review please? |
jdevalk
reviewed
Jul 18, 2025
Signed-off-by: Andy Fragen <[email protected]>
Signed-off-by: Andy Fragen <[email protected]>
Signed-off-by: Andy Fragen <[email protected]>
costdev
approved these changes
Jul 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR splits the
compat.phpinto WP and PHP polyfills.It assumes a minimum PHP version of 7.4.
It assumes a minimum WordPress version of 5.3 as this is the first WordPress version compatible with PHP 7.4.
I have not adjusted the GitHub Actions or the plugin Requires headers for these data.