Skip to content

Conversation

@afragen
Copy link
Contributor

@afragen afragen commented Jun 7, 2025

#5 will result in issues for any other users of the Git Updater Lite library and may not solve the issue if another instance of GUL is loaded before FAIR.

I believe the actual solution is to change the REST route on the api.fair.pm site so that the GUL library in its unmodified form will function for everyone.

Signed-off-by: Andy Fragen <[email protected]>
@afragen afragen requested a review from rmccue June 7, 2025 02:47
Signed-off-by: Andy Fragen <[email protected]>
@szepeviktor
Copy link
Contributor

This PR adds wp-json to the URL.

@afragen
Copy link
Contributor Author

afragen commented Jun 9, 2025

Yes, this PR adds wp-json to the REST route for the reasons stated above.

Signed-off-by: Andy Fragen <[email protected]>
@afragen
Copy link
Contributor Author

afragen commented Jun 9, 2025

Ready for review

@afragen afragen requested review from Ipstenu and removed request for rmccue June 11, 2025 14:50
Copy link
Contributor

@Ipstenu Ipstenu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks fine, but @rmccue should weigh in before we merge

@afragen afragen requested a review from rmccue June 11, 2025 15:28
@afragen
Copy link
Contributor Author

afragen commented Jun 11, 2025

FWIW this is the same code as in the current GUL release.

@Ipstenu
Copy link
Contributor

Ipstenu commented Jun 11, 2025

FWIW this is the same code as in the current GUL release.

I know, it's this:

I believe the actual solution is to change the REST route on the api.fair.pm site so that the GUL library in its unmodified form will function for everyone.

I want Ryan to confirm that's done (or that he's got a ticket for it ;) )

Copy link
Member

@rmccue rmccue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Server PR opened in fairpm/server#5 to handle the redirect.

@afragen afragen merged commit c156fdd into main Jun 11, 2025
1 check passed
@afragen afragen deleted the revert-PR5 branch June 11, 2025 19:15
@rmccue rmccue added this to the 0.3.0 milestone Jun 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants