-
Notifications
You must be signed in to change notification settings - Fork 40
Revert https://github.com/fairpm/fair-plugin/pull/5 #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Andy Fragen <[email protected]>
Signed-off-by: Andy Fragen <[email protected]>
|
This PR adds |
|
Yes, this PR adds |
Signed-off-by: Andy Fragen <[email protected]>
|
Ready for review |
Ipstenu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks fine, but @rmccue should weigh in before we merge
|
FWIW this is the same code as in the current GUL release. |
I know, it's this:
I want Ryan to confirm that's done (or that he's got a ticket for it ;) ) |
rmccue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Server PR opened in fairpm/server#5 to handle the redirect.
#5 will result in issues for any other users of the Git Updater Lite library and may not solve the issue if another instance of GUL is loaded before FAIR.
I believe the actual solution is to change the REST route on the
api.fair.pmsite so that the GUL library in its unmodified form will function for everyone.