fix: improve deadlock fix with forked deadlocks detection#1
Closed
raythurnvoid wants to merge 53 commits intofairbanksg:fix-ssr-hangfrom
raythurnvoid:improve_deadlock_deps_fix
Closed
fix: improve deadlock fix with forked deadlocks detection#1raythurnvoid wants to merge 53 commits intofairbanksg:fix-ssr-hangfrom raythurnvoid:improve_deadlock_deps_fix
raythurnvoid wants to merge 53 commits intofairbanksg:fix-ssr-hangfrom
raythurnvoid:improve_deadlock_deps_fix
Conversation
…#3694) See discussions at <vitejs#3656 (comment)>
…nerated maps (vitejs#3684) * fix(types): add hidden to sourcemap * docs: update sourcemap config
Co-authored-by: Renovate Bot <[email protected]> Co-authored-by: Anthony Fu <[email protected]>
Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) --- updated-dependencies: - dependency-name: hosted-git-info dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…tejs#3792) Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
Co-authored-by: Renovate Bot <[email protected]>
…vitejs#3747) Co-authored-by: Shinigami <[email protected]>
9 tasks
If dependencies are not loaded one at a time, the load order depends on the depth of the dependency tree plus the transformation time per module. When forced to load serially, the load orders depends on the order of import declarations, which is how NodeJS works too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This aim to fix a particular type of circular dependency that causes tricky deadlocks, deadlocks with forked imports stack
Forked deadlock description:
This may seems a traditional deadlock, but the thing that makes this special is the import stack of each module:
Even if
[X]is imported by[B],[B]is not in[X]'s stack because it's imported by[H]in first place then it's stack is only composed by[H].[H]forks the imports stack and this make hard to be found.Fix description
Vite, when imports
[X], should check whether[X]is already pending and if it is, it must check that, when it was imported in first place, the stack of[X]doesn't have any module in common with the current module; in this case[B]has the module[H]is common with[X]and i can assume that a deadlock is going to happen.What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).