Removed the -no auth attempts- from the triggers because of lots of FP#600
Merged
grooverdan merged 4 commits intofail2ban:masterfrom Jan 31, 2014
Merged
Removed the -no auth attempts- from the triggers because of lots of FP#600grooverdan merged 4 commits intofail2ban:masterfrom
grooverdan merged 4 commits intofail2ban:masterfrom
Conversation
Contributor
|
Actually grouping the test cases you've removed and changing the "match" to "false" in failJSON would be good so we don't accidentally cover this again. I'm ok with this change. Wouldn't mind someone else confirming it. |
Contributor
|
👍 I've noticed that when connections drop from bad mobile phone signal this can trip... |
… to avoid accidentally reenabling them in the future
… to avoid accidentally reenabling them in the future
Contributor
|
thank you. I've merged this in #601 with additional samples from the mailing list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to dovecot's wiki http://wiki2.dovecot.org/WhyDoesItNotWork
Looking on our logs, I found plenty of legitimate clients facing this error, and found on the internet reports for many mail clients (thunderbird, kmail, outlook, ..), just have a look at "no auth attempts" at google. Most of the times is mail client fault
Hence I disabled this from the regexp and adjusted both the sample logs and the code.