Skip to content

chore: Add all env test workflow#77

Merged
LeeDongGeon1996 merged 20 commits intofacioquo:mainfrom
LeeDongGeon1996:tests/compat-py-version
Jan 24, 2024
Merged

chore: Add all env test workflow#77
LeeDongGeon1996 merged 20 commits intofacioquo:mainfrom
LeeDongGeon1996:tests/compat-py-version

Conversation

@LeeDongGeon1996
Copy link
Collaborator

@LeeDongGeon1996 LeeDongGeon1996 commented Dec 7, 2021

Description

  • Add all env test workflow

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996 LeeDongGeon1996 deleted the tests/compat-py-version branch January 19, 2022 02:00
@LeeDongGeon1996 LeeDongGeon1996 restored the tests/compat-py-version branch January 19, 2022 04:14
@LeeDongGeon1996 LeeDongGeon1996 changed the title test: Add 3.7 and 3.8 to test-matrix tests: Add 3.7 and 3.8 to test-matrix Jan 20, 2022
@LeeDongGeon1996 LeeDongGeon1996 changed the title tests: Add 3.7 and 3.8 to test-matrix tests: Add 3.7, 3.9 and 3.10 to test-matrix Apr 11, 2022
@LeeDongGeon1996 LeeDongGeon1996 force-pushed the tests/compat-py-version branch from 7664aad to 675ea81 Compare April 11, 2022 09:41
@lgtm-com
Copy link

lgtm-com bot commented Apr 11, 2022

This pull request fixes 1 alert when merging 675ea81 into cff4923 - view on LGTM.com

fixed alerts:

  • 1 for Unused import

@LeeDongGeon1996 LeeDongGeon1996 force-pushed the tests/compat-py-version branch 2 times, most recently from f0d8a60 to f256dec Compare April 13, 2022 07:21
@LeeDongGeon1996 LeeDongGeon1996 changed the title tests: Add 3.7, 3.9 and 3.10 to test-matrix chore: Add 3.7, 3.9 and 3.10 to test-matrix Apr 13, 2022
@LeeDongGeon1996 LeeDongGeon1996 changed the title chore: Add 3.7, 3.9 and 3.10 to test-matrix chore: Add 3.7-3.11 to test-matrix Jan 1, 2023
@DaveSkender
Copy link
Member

DaveSkender commented Dec 31, 2023

I suspect you’re not merging this to main due to the excessive workload. Consider making this a separate manual on: workflow_dispatch triggered GitHub Action instead, so we can spawn it when desired.

And possibly have it also run performance tests on one setup only, see example: test-performance.yml

@LeeDongGeon1996 LeeDongGeon1996 force-pushed the tests/compat-py-version branch 4 times, most recently from 65c6048 to 243ee07 Compare January 24, 2024 14:38
@LeeDongGeon1996 LeeDongGeon1996 force-pushed the tests/compat-py-version branch from db13380 to ff33cce Compare January 24, 2024 15:19
@LeeDongGeon1996 LeeDongGeon1996 changed the title chore: Add 3.7-3.11 to test-matrix chore: Add all evn test workflow Jan 24, 2024
@LeeDongGeon1996 LeeDongGeon1996 marked this pull request as ready for review January 24, 2024 15:20
@LeeDongGeon1996
Copy link
Collaborator Author

there's no conditional on setting matrix. 😱

@LeeDongGeon1996 LeeDongGeon1996 changed the title chore: Add all evn test workflow chore: Add all env test workflow Jan 24, 2024
@LeeDongGeon1996 LeeDongGeon1996 enabled auto-merge (squash) January 24, 2024 15:23
@LeeDongGeon1996 LeeDongGeon1996 merged commit 508e9b0 into facioquo:main Jan 24, 2024
@LeeDongGeon1996 LeeDongGeon1996 deleted the tests/compat-py-version branch January 24, 2024 16:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants