Skip to content

fix: Debian (macOS) compatibility (and GH workflows)#415

Merged
DaveSkender merged 42 commits intomainfrom
update-gh-workflows
Jan 22, 2025
Merged

fix: Debian (macOS) compatibility (and GH workflows)#415
DaveSkender merged 42 commits intomainfrom
update-gh-workflows

Conversation

@DaveSkender
Copy link
Member

@DaveSkender DaveSkender commented Jan 20, 2025

primary changes

  • Update workflows to newer requirements
  • Add separate localization and performance test (with summary) workflows
  • Add .NET 9 framework targeting in workflows
  • refactor: Tests to increase use of marker-based targeting
  • fix: possible MacOs issue #408 (see this commit)

The macOS (Darwin) compatibility issue was primarily due to the way it uniquely sets and uses .NET, and did not appear to be related to the underlying .NET DLL itself. I've updated the primary Python.NET loader to better handle and provide debug information; as well as some related troubleshooting docs for users.

@DaveSkender DaveSkender self-assigned this Jan 20, 2025
@DaveSkender

This comment was marked as resolved.

@DaveSkender DaveSkender changed the title refactor: Workflow cleanup fix: macOS Debian compatibility Jan 21, 2025
@DaveSkender DaveSkender changed the title fix: macOS Debian compatibility fix: Debian (macOS) compatibility Jan 21, 2025
@DaveSkender DaveSkender marked this pull request as ready for review January 21, 2025 03:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 118 out of 132 changed files in this pull request and generated no comments.

Files not reviewed (14)
  • .editorconfig: Language not supported
  • .github/workflows/test-docs-a11y.yml: Language not supported
  • .github/workflows/test-docs-links.yml: Language not supported
  • .github/workflows/test-indicators-all-env.yml: Language not supported
  • .pylintrc: Language not supported
  • docs/.pa11yci: Language not supported
  • .github/workflows/test-code-coverage.yml: Evaluated as low risk
  • .github/workflows/test-indicators-full.yml: Evaluated as low risk
  • .github/workflows/test-indicators.yml: Evaluated as low risk
  • .github/workflows/test-localization.yml: Evaluated as low risk
  • .github/dependabot.yml: Evaluated as low risk
  • .github/workflows/deploy-website.yml: Evaluated as low risk
  • benchmarks/test_benchmark_indicators.py: Evaluated as low risk
  • benchmarks/conftest.py: Evaluated as low risk

@DaveSkender DaveSkender mentioned this pull request Jan 21, 2025
@DaveSkender DaveSkender changed the title fix: Debian (macOS) compatibility fix: Debian (macOS) compatibility (and GH workflows) Jan 21, 2025
@DaveSkender DaveSkender removed the request for review from LeeDongGeon1996 January 21, 2025 13:39
@DaveSkender DaveSkender merged commit 080dcde into main Jan 22, 2025
27 checks passed
@DaveSkender DaveSkender deleted the update-gh-workflows branch January 22, 2025 00:37
@LeeDongGeon1996
Copy link
Collaborator

Thanks for your work 🙂

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

possible MacOs issue

3 participants