Merged
Conversation
and add baseline .vscode configs
DaveSkender
changed the title
DaveSkender
changed the title
Contributor
There was a problem hiding this comment.
Copilot reviewed 98 out of 113 changed files in this pull request and generated no comments.
Files not reviewed (15)
- .devcontainer/devcontainer.json: Language not supported
- .devcontainer/install-dependencies.sh: Language not supported
- .editorconfig: Language not supported
- .gitattributes: Language not supported
- .github/workflows/test-docs-a11y.yml: Language not supported
- .github/workflows/test-docs-links.yml: Language not supported
- .github/workflows/test-indicators-all-env.yml: Language not supported
- .pylintrc: Language not supported
- .vscode/extensions.json: Language not supported
- .vscode/launch.json: Language not supported
- .vscode/settings.json: Language not supported
- .vscode/tasks.json: Language not supported
- .github/workflows/deploy-website.yml: Evaluated as low risk
- .github/workflows/test-indicators-ci.yml: Evaluated as low risk
- .github/workflows/test-indicators-coverage.yml: Evaluated as low risk
Comments suppressed due to low confidence (2)
.github/workflows/test-indicators-full.yml:24
- [nitpick] The variable name 'IS_PRIMARY' is ambiguous. It should be renamed to something more descriptive, such as 'IS_PRIMARY_INSTANCE'.
IS_PRIMARY: ${{ matrix.os == 'macos-latest' && matrix.python-version == '3.12' && matrix.dotnet-version == '8.x' }}
.github/workflows/test-indicators-full.yml:50
- Ensure that the new behavior introduced by the changes is covered by tests.
run: pytest -vr A tests --junitxml=test-results.xml
DaveSkender
commented
Jan 20, 2025
github-project-automation
bot
moved this from 🏗 In progress
to ✅ Done
in Stock Indicators for Python
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the development environment and test configurations while improving compatibility with workspaces. Key changes include updating the dev container to use Python 3.12 and adding new VS Code configuration files for tasks, settings, launch, and extensions.
.vscodeconfig filesdetails
the details
This pull request introduces a comprehensive update to the development environment configuration for the Python project, focusing on enhancing usability, consistency, and developer productivity. Key changes include upgrading the devcontainer setup, adding VS Code configurations for debugging and testing, and updating documentation to reflect the new environment setup.
Devcontainer and Environment Configuration Updates:
.devcontainer/devcontainer.json: Upgraded the Python version to 3.12 and added several development features, including Git, Node.js, Ruby, Azure CLI, and GitHub CLI. Updated post-create and post-start commands for better automation..devcontainer/setup.sh: Added a script to install core and test dependencies automatically after the container is created.VS Code Configuration Enhancements:
.vscode/extensions.json: Defined recommended extensions for Python development, including linters, formatters, and debugging tools..vscode/launch.json: Added debugging configurations for running Python files and tests usingdebugpy..vscode/settings.json: Configured settings forisort,markdownlint,pylint, and Python testing to ensure consistency and enforce coding standards..vscode/tasks.json: Added predefined tasks for building dependencies, running unit tests, performance tests, localization tests, and coverage analysis.Documentation Updates:
docs/contributing.md: Revised the "Development Environment" section to highlight the use of VS Code Dev Containers and tools likeactfor testing GitHub Actions workflows locally. Simplified instructions for new contributors. [1] [2]