Merged
Conversation
DaveSkender
approved these changes
May 4, 2024
Member
There was a problem hiding this comment.
You may want to also do one or more of these optional items here too, but otherwise LGTM.
- update /docs/pages/performance.md in #379
- add a
workflow_dispatchrunner like we've done here, that publishes results
On the .NET project, I'm trying to decide whether to keep the separate docs performance page and just keep the runner (and just link to it in docs) or if there's a better way to simply generate that page. For now, I've been using both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist