feat: Add condense() on all supported indicators#377
Merged
LeeDongGeon1996 merged 12 commits intofacioquo:mainfrom May 4, 2024
Merged
feat: Add condense() on all supported indicators#377LeeDongGeon1996 merged 12 commits intofacioquo:mainfrom
condense() on all supported indicators#377LeeDongGeon1996 merged 12 commits intofacioquo:mainfrom
Conversation
17 tasks
Collaborator
Author
|
@DaveSkender I think Codacy config is reset. Please exclude |
condense() on all supported indicators
DaveSkender
approved these changes
May 4, 2024
Member
There was a problem hiding this comment.
nicely done. getting these extensions done well will make chaining (and then streaming) a bit easier when we eventually get to those parts.
indicators.get_alligator(quotes).condense()do you think this will be possible soon too?
quotes.get_alligator().condense()
Collaborator
Author
|
That's the part I'm worried about recently. As I mentioned above, extension method is not supported, so we may need to find another approach to implement those features(chaining, streaming) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
typing_extensionsto 4.4.0 for@overrideIssue
pythonnetdoes not support extension method yetChecklist