Skip to content

docs: Add blurb for trouble with converting to quotes#352

Merged
LeeDongGeon1996 merged 6 commits intofacioquo:mainfrom
LeeDongGeon1996:docs/add-convering-quotes-faq
Mar 5, 2024
Merged

docs: Add blurb for trouble with converting to quotes#352
LeeDongGeon1996 merged 6 commits intofacioquo:mainfrom
LeeDongGeon1996:docs/add-convering-quotes-faq

Conversation

@LeeDongGeon1996
Copy link
Collaborator

@LeeDongGeon1996 LeeDongGeon1996 commented Mar 2, 2024

Description

  • Add blurb for trouble with converting to quotes

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996
Copy link
Collaborator Author

I've just add short blurb as we discussed and this is for general cases, not only for locale issue.

@DaveSkender
Copy link
Member

I'm done tweaking, go ahead and merge if you're ready.

@LeeDongGeon1996
Copy link
Collaborator Author

@DaveSkender do we have code coverage badge from Codacy now? I can't find with my permission.

@DaveSkender
Copy link
Member

DaveSkender commented Mar 2, 2024

do we have code coverage badge from Codacy now? I can't find with my permission.

I've removed them from the permanent README.md aspects that get published with packages in #347, given how much trouble they've been. You probably can't see this settings page with the badge info.

[![Codacy Badge](https://app.codacy.com/project/badge/Coverage/2b48204b1e304e3bac977fbc92b19c14)](https://app.codacy.com/gh/DaveSkender/Stock.Indicators.Python/dashboard)

Codacy Badge

For the .NET site, I'd only put it on the contributing page.

@LeeDongGeon1996
Copy link
Collaborator Author

given how much trouble they've been.

You mean showing this badge has had trouble frequently?

@DaveSkender
Copy link
Member

DaveSkender commented Mar 2, 2024

You mean showing this badge has had trouble frequently?

  1. It's just been hard to get them to work with Codacy
  2. Legacy package manager pages that are permanent have old Azure DevOps badges that are now broken when I turn off those old builds; pages like on nuget.org and pypi.org -- don't want to make the same mistake if/when we move off of Codacy

@LeeDongGeon1996
Copy link
Collaborator Author

LeeDongGeon1996 commented Mar 4, 2024

@DaveSkender I added in the same page.
Could you set ignoring some files like docs or tests in Codacy?

@DaveSkender
Copy link
Member

@DaveSkender I added in the same page. Could you set ignoring some files like docs or tests in Codacy?

Updated:
image

@LeeDongGeon1996 LeeDongGeon1996 merged commit 9dbc050 into facioquo:main Mar 5, 2024
@LeeDongGeon1996 LeeDongGeon1996 deleted the docs/add-convering-quotes-faq branch March 5, 2024 13:31
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants