Skip to content

feat: Add Dominant Cycle Periods to HT Trendline#341

Merged
LeeDongGeon1996 merged 1 commit intofacioquo:mainfrom
LeeDongGeon1996:feature/add-dcperiods-httrendline
Jan 18, 2024
Merged

feat: Add Dominant Cycle Periods to HT Trendline#341
LeeDongGeon1996 merged 1 commit intofacioquo:mainfrom
LeeDongGeon1996:feature/add-dcperiods-httrendline

Conversation

@LeeDongGeon1996
Copy link
Collaborator

@LeeDongGeon1996 LeeDongGeon1996 commented Jan 17, 2024

Description

  • Add Dominant Cycle Periods to HT Trendline

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996 LeeDongGeon1996 marked this pull request as ready for review January 17, 2024 13:45
Copy link
Member

@DaveSkender DaveSkender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One new thing to note. Since we changed the way the document site is deployed, you can add documentation updates with the corresponding code changes in one PR, without it actually updating the site. We deploy the site as needed.

@LeeDongGeon1996
Copy link
Collaborator Author

Oh, right. Thank you for reminding me. But, I plan to do all docs updates in one separate pr :)

@LeeDongGeon1996 LeeDongGeon1996 merged commit c6d47bd into facioquo:main Jan 18, 2024
@LeeDongGeon1996 LeeDongGeon1996 deleted the feature/add-dcperiods-httrendline branch January 18, 2024 13:24
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants