Skip to content

test: Update conftest not to use openpyxl#335

Merged
LeeDongGeon1996 merged 2 commits intofacioquo:mainfrom
LeeDongGeon1996:test/update-conftest-benchmark
Jan 3, 2024
Merged

test: Update conftest not to use openpyxl#335
LeeDongGeon1996 merged 2 commits intofacioquo:mainfrom
LeeDongGeon1996:test/update-conftest-benchmark

Conversation

@LeeDongGeon1996
Copy link
Collaborator

@LeeDongGeon1996 LeeDongGeon1996 commented Jan 3, 2024

Description

  • Update conftest not to use openpyxl

Fixes #331

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996 LeeDongGeon1996 marked this pull request as ready for review January 3, 2024 13:24
@LeeDongGeon1996 LeeDongGeon1996 enabled auto-merge (squash) January 3, 2024 13:26
@LeeDongGeon1996 LeeDongGeon1996 merged commit 6e1718b into facioquo:main Jan 3, 2024
@LeeDongGeon1996 LeeDongGeon1996 deleted the test/update-conftest-benchmark branch January 3, 2024 15:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test data now from csv, remove openpyxl

2 participants