Skip to content

chore: Update package build command#327

Merged
LeeDongGeon1996 merged 8 commits intofacioquo:mainfrom
LeeDongGeon1996:chore/modernize-setup-py
Dec 27, 2023
Merged

chore: Update package build command#327
LeeDongGeon1996 merged 8 commits intofacioquo:mainfrom
LeeDongGeon1996:chore/modernize-setup-py

Conversation

@LeeDongGeon1996
Copy link
Collaborator

@LeeDongGeon1996 LeeDongGeon1996 commented Dec 27, 2023

Description

  • Update package build command

fixes #325

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996 LeeDongGeon1996 changed the title Chore/modernize setup py chore: Update package build command Dec 27, 2023
@LeeDongGeon1996 LeeDongGeon1996 marked this pull request as ready for review December 27, 2023 03:58
@LeeDongGeon1996 LeeDongGeon1996 enabled auto-merge (squash) December 27, 2023 03:58
@LeeDongGeon1996 LeeDongGeon1996 merged commit 264f294 into facioquo:main Dec 27, 2023
@LeeDongGeon1996
Copy link
Collaborator Author

@DaveSkender setuptools_scm cannnot get the latest version...

@DaveSkender
Copy link
Member

@DaveSkender setuptools_scm cannnot get the latest version...

Is it supposed to auto-increment, or does it require manual tagging? I know GitVersion had a quirk about tag history, you had to make sure you checkout the full history.

      - name: Checkout repository
        uses: actions/checkout@v4
        with:
          fetch-depth: 0

@LeeDongGeon1996 LeeDongGeon1996 deleted the chore/modernize-setup-py branch December 27, 2023 17:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incompatible test.pypi.org version number

2 participants