Skip to content

fix: Fix converting C# timezone-aware DateTime#321

Merged
LeeDongGeon1996 merged 2 commits intofacioquo:mainfrom
LeeDongGeon1996:fix/converting-datetime
Dec 25, 2023
Merged

fix: Fix converting C# timezone-aware DateTime#321
LeeDongGeon1996 merged 2 commits intofacioquo:mainfrom
LeeDongGeon1996:fix/converting-datetime

Conversation

@LeeDongGeon1996
Copy link
Collaborator

@LeeDongGeon1996 LeeDongGeon1996 commented Dec 12, 2023

Description

  • Fix converting C# timezone-aware DateTime
  • timezone data will be ignored.

Fixes #310

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996 LeeDongGeon1996 marked this pull request as ready for review December 23, 2023 08:59
Copy link
Member

@DaveSkender DaveSkender left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be interesting to see what this does for performance, given the frequency of this operation.

@LeeDongGeon1996
Copy link
Collaborator Author

LeeDongGeon1996 commented Dec 25, 2023

maybe there's no significant improvement that can be felt by user, because converting datetime is occured only when user calls getter

@LeeDongGeon1996 LeeDongGeon1996 merged commit dd36ea2 into facioquo:main Dec 25, 2023
@LeeDongGeon1996 LeeDongGeon1996 deleted the fix/converting-datetime branch December 26, 2023 05:41
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants