Skip to content

chore: Bump dll to 2.5.0#318

Merged
LeeDongGeon1996 merged 6 commits intofacioquo:mainfrom
LeeDongGeon1996:chore/bump-dll-2.5.0
Dec 11, 2023
Merged

chore: Bump dll to 2.5.0#318
LeeDongGeon1996 merged 6 commits intofacioquo:mainfrom
LeeDongGeon1996:chore/bump-dll-2.5.0

Conversation

@LeeDongGeon1996
Copy link
Collaborator

@LeeDongGeon1996 LeeDongGeon1996 commented Dec 9, 2023

Description

  • Bump dll to 2.5.0

Compatibility

Target framework of dll / Runtime .NET 6 .NET 7 .NET 8
6 88ms 82ms 70ms
7 90ms 85ms 69ms
8 N/A N/A 70ms

(test benchmark method: test_benchmark_hurst_longlong )

Checklist

  • My code follows the existing style, code structure, and naming taxonomy
  • I have commented my code, particularly in hard-to-understand areas
  • I have performed a self-review of my own code and included any verifying manual calculations
  • I have added or updated unit tests that prove my fix is effective or that my feature works, and achieves sufficient code coverage. New and existing unit tests pass locally and in the build (below) with my changes
  • My changes generate no new warnings and running code analysis does not produce any issues
  • I have added or run the performance tests that depict optimal execution times
  • I have made corresponding changes to the documentation

@LeeDongGeon1996 LeeDongGeon1996 marked this pull request as draft December 9, 2023 12:58
@LeeDongGeon1996 LeeDongGeon1996 marked this pull request as ready for review December 11, 2023 03:51
@LeeDongGeon1996
Copy link
Collaborator Author

@DaveSkender , Could you check CI trigger?

@DaveSkender
Copy link
Member

@DaveSkender , Could you check CI trigger?

Yep, not sure what's going on there. Checking ...

@LeeDongGeon1996
Copy link
Collaborator Author

Thanks!! 😁

@DaveSkender
Copy link
Member

Go ahead and merge and let me know if you want this deployed to PyPI now vs. later. I've added an issue as a reminder for us to migrate to GitHub Action build and deployments like I've done recently for the C# project.

@LeeDongGeon1996
Copy link
Collaborator Author

Thanks. I have some another tasks for next deployment, so I'll let you know later

@LeeDongGeon1996 LeeDongGeon1996 merged commit 7124d9c into facioquo:main Dec 11, 2023
@LeeDongGeon1996 LeeDongGeon1996 deleted the chore/bump-dll-2.5.0 branch December 26, 2023 05:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants