Conversation
There was a problem hiding this comment.
First of all, thank you for contributing! I love what you're doing here, long overdue.
In addition to the specific comments, I have a general thought that duplicating these CSV files from the source seems a bit icky, but I also think referencing another repo is not a great practice. Can you think of a way to simply use the source CSV files rather than putting them here? The only reason I suggest it is that these tests mirror the originating DLL tests and I'd really only want to maintain these CSV files there, ideally, and not have to worry about syncing it here too.
no problem 😊, just happen to stumble upon this dinosaur fossil 🤣
i see what you meant. I'm not too sure if there is a method for this that works with |
|
@LeeDongGeon1996 take a quick peek and merge when ready, LGTM. |
LeeDongGeon1996
left a comment
There was a problem hiding this comment.
Thanks for your contribution !!
I've just left some comments. Please check when you're available :)
|
One or more of these files aren’t importing correctly, not sure which ones. Unit tests are blowing up. |
|
I think so. My hypothesis is based on all tests passing as of ab5cce9 previously. |
|
ok i found the issue, there are several csv that don't follow the current parsing rules. ill fix them |
|
ok fixed! lets wait for the tests to complete |
|
LGTM, thanks! |
|
Thanks for contributing @alexpvpmindustry, much appreciated. ❤️ |


Description
migrated from
samples/quotes/History.xlsxtosamples/quotes/*.csvremoved dependency of
from openpyxl import load_workbookintests/conftest.pyFixes #188
Checklist