Merged
Conversation
- Scoped ASCII/Unicode flags (`(?a:pattern)`/`(?u:pattern)`) should be respected for Unicode properties in `bre`. - Fix issues with disabled scoped flags.
gir-bot
added
S: needs-review
facelessuser
force-pushed
the
bugfix/scoped-flags
branch
from
9c5ec29 to
105279c
Compare
- Regex will allow global flags in scoped groups, but they still apply globally. - Regex allows disables in non-scoped groups.
facelessuser
force-pushed
the
bugfix/scoped-flags
branch
from
fe8a85d to
e1009e2
Compare
Owner
Author
|
@gir-bot lgtm |
gir-bot
added
S: approved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(?a:pattern)/(?u:pattern)) should be respected for Unicode properties inbre.