support specifying matching_heuristics from filename#118
Closed
wat3rBro wants to merge 1 commit intofacebookresearch:mainfrom
Closed
support specifying matching_heuristics from filename#118wat3rBro wants to merge 1 commit intofacebookresearch:mainfrom
wat3rBro wants to merge 1 commit intofacebookresearch:mainfrom
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41145857 |
wat3rBro
pushed a commit
to wat3rBro/fvcore
that referenced
this pull request
Nov 9, 2022
…h#118) Summary: Pull Request resolved: facebookresearch#118 X-link: facebookresearch/detectron2#4650 D35519683 changed the default `matching_heuristics` from `False` to `True`, it may cause some issues: - potential bug report: https://fb.workplace.com/groups/2240361332735959/posts/5264606250311437/?comment_id=5265167493588646 - bloated logging: facebookresearch/detectron2#4364 This diff reverts the default value back to `False`, and introduce a way to specify this option via filename url. Differential Revision: D41145857 fbshipit-source-id: 6b2ddb20ba03372d16b161b3dc48238c35987d30
wat3rBro
force-pushed
the
export-D41145857
branch
from
de11759 to
57dfcf3
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41145857 |
wat3rBro
pushed a commit
to wat3rBro/fvcore
that referenced
this pull request
Nov 9, 2022
…h#118) Summary: Pull Request resolved: facebookresearch#118 X-link: facebookresearch/detectron2#4650 D35519683 changed the default `matching_heuristics` from `False` to `True`, it may cause some issues: - potential bug report: https://fb.workplace.com/groups/2240361332735959/posts/5264606250311437/?comment_id=5265167493588646 - bloated logging: facebookresearch/detectron2#4364 This diff reverts the default value back to `False`, and introduce a way to specify this option via filename url. Differential Revision: D41145857 fbshipit-source-id: b49b940efa3459e44a1f09f9af9c3d0225940932
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41145857 |
wat3rBro
force-pushed
the
export-D41145857
branch
from
57dfcf3 to
b69c753
Compare
Contributor
|
Thanks a lot for doing this! I think you'd have to bump the version number and let detectron2 depend on this version of fvcore. Also, new versions of fvcore get published to pypi automatically through circleci, only if cpu/gpu tests passed.. Unfortunately, tests have been broken for many months, so that's another dependency.. 😢 |
Contributor
|
An alternative is to overwrite |
wat3rBro
pushed a commit
to wat3rBro/fvcore
that referenced
this pull request
Nov 21, 2022
…h#118) Summary: Pull Request resolved: facebookresearch#118 X-link: facebookresearch/detectron2#4650 D35519683 changed the default `matching_heuristics` from `False` to `True`, it may cause some issues: - potential bug report: https://fb.workplace.com/groups/2240361332735959/posts/5264606250311437/?comment_id=5265167493588646 - bloated logging: facebookresearch/detectron2#4364 This diff reverts the default value back to `False`, and introduce a way to specify this option via filename url. Differential Revision: D41145857 fbshipit-source-id: 910c28ca92a8c01946a1455545e9ce9745ed9e3c
wat3rBro
force-pushed
the
export-D41145857
branch
from
b69c753 to
99c0571
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41145857 |
wat3rBro
pushed a commit
to wat3rBro/fvcore
that referenced
this pull request
Nov 22, 2022
…h#118) Summary: Pull Request resolved: facebookresearch#118 X-link: facebookresearch/detectron2#4650 D35519683 changed the default `matching_heuristics` from `False` to `True`, it may cause some issues: - potential bug report: https://fb.workplace.com/groups/2240361332735959/posts/5264606250311437/?comment_id=5265167493588646 - bloated logging: facebookresearch/detectron2#4364 This diff reverts the default value back to `False`, and introduce a way to specify this option via filename url. Differential Revision: D41145857 fbshipit-source-id: a89374071177510972865a8afb80eebe74cf0513
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41145857 |
wat3rBro
force-pushed
the
export-D41145857
branch
from
99c0571 to
c2cf05b
Compare
wat3rBro
pushed a commit
to wat3rBro/detectron2-1
that referenced
this pull request
Dec 16, 2022
Summary: X-link: facebookresearch/fvcore#118 Pull Request resolved: facebookresearch#4650 D35519683 (facebookresearch@0ad20f1) changed the default `matching_heuristics` from `False` to `True`, it may cause some issues: - potential bug report: https://fb.workplace.com/groups/2240361332735959/posts/5264606250311437/?comment_id=5265167493588646 - bloated logging: facebookresearch#4364 This diff reverts the default value back to `False`, and introduce a way to specify this option via filename url. Reviewed By: lyttonhao Differential Revision: D41145857 fbshipit-source-id: 2ee5feb6505260509bc5c0367b7c4048fbe377c8
wat3rBro
pushed a commit
to wat3rBro/detectron2-1
that referenced
this pull request
Dec 16, 2022
Summary: X-link: facebookresearch/fvcore#118 Pull Request resolved: facebookresearch#4650 D35519683 (facebookresearch@0ad20f1) changed the default `matching_heuristics` from `False` to `True`, it may cause some issues: - potential bug report: https://fb.workplace.com/groups/2240361332735959/posts/5264606250311437/?comment_id=5265167493588646 - bloated logging: facebookresearch#4364 This diff reverts the default value back to `False`, and introduce a way to specify this option via filename url. Differential Revision: https://internalfb.com/D41145857 fbshipit-source-id: 1daa202d9cf48dddaee6d00d84306ef9dbc7e2a9
wat3rBro
pushed a commit
to wat3rBro/detectron2-1
that referenced
this pull request
Dec 19, 2022
Summary: X-link: facebookresearch/fvcore#118 Pull Request resolved: facebookresearch#4650 D35519683 (facebookresearch@0ad20f1) changed the default `matching_heuristics` from `False` to `True`, it may cause some issues: - potential bug report: https://fb.workplace.com/groups/2240361332735959/posts/5264606250311437/?comment_id=5265167493588646 - bloated logging: facebookresearch#4364 This diff reverts the default value back to `False`, and introduce a way to specify this option via filename url. Reviewed By: lyttonhao Differential Revision: D41145857 fbshipit-source-id: 94d5a4e310207e0f33119af7293161313ff2d256
…h#118) Summary: Pull Request resolved: facebookresearch#118 X-link: facebookresearch/detectron2#4650 D35519683 changed the default `matching_heuristics` from `False` to `True`, it may cause some issues: - potential bug report: https://fb.workplace.com/groups/2240361332735959/posts/5264606250311437/?comment_id=5265167493588646 - bloated logging: facebookresearch/detectron2#4364 This diff reverts the default value back to `False`, and introduce a way to specify this option via filename url. Reviewed By: lyttonhao Differential Revision: D41145857 fbshipit-source-id: e987b5ab8e8c78a6218f1e29dc394da8faca49f5
wat3rBro
force-pushed
the
export-D41145857
branch
from
c2cf05b to
49d0268
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D41145857 |
facebook-github-bot
pushed a commit
to facebookresearch/detectron2
that referenced
this pull request
Dec 20, 2022
Summary: X-link: facebookresearch/fvcore#118 Pull Request resolved: #4650 D35519683 (0ad20f1) changed the default `matching_heuristics` from `False` to `True`, it may cause some issues: - potential bug report: https://fb.workplace.com/groups/2240361332735959/posts/5264606250311437/?comment_id=5265167493588646 - bloated logging: #4364 This diff reverts the default value back to `False`, and introduce a way to specify this option via filename url. Reviewed By: lyttonhao Differential Revision: D41145857 fbshipit-source-id: 5ad1cfcebaeab8ebc4e48f0e2b9d50c33ba777dd
Contributor
|
This pull request has been merged in d194d76. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D35519683 changed the default
matching_heuristicsfromFalsetoTrue, it may cause some issues:This diff reverts the default value back to
False, and introduce a way to specify this option via filename url.Differential Revision: D41145857