This repository was archived by the owner on Jan 22, 2025. It is now read-only.
upgrade pytorch-lightning version#453
Closed
wat3rBro wants to merge 1 commit intofacebookresearch:mainfrom
Closed
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42319019 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42319019 |
wat3rBro
pushed a commit
to wat3rBro/d2go
that referenced
this pull request
Jan 3, 2023
Summary: Pull Request resolved: facebookresearch#453 Differential Revision: D42319019 fbshipit-source-id: bd0b964ce79917abaaef0d00e245b8aa7a34c0cd
wat3rBro
force-pushed
the
export-D42319019
branch
from
39f122c to
6036ba8
Compare
wat3rBro
pushed a commit
to wat3rBro/d2go
that referenced
this pull request
Jan 3, 2023
Summary: Pull Request resolved: facebookresearch#453 Differential Revision: D42319019 fbshipit-source-id: d6434517a25eb1cec20ed4fc851bd806b5f8ed74
wat3rBro
force-pushed
the
export-D42319019
branch
from
6036ba8 to
054dc8c
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42319019 |
wat3rBro
pushed a commit
to wat3rBro/d2go
that referenced
this pull request
Jan 3, 2023
Summary: Pull Request resolved: facebookresearch#453 Differential Revision: D42319019 fbshipit-source-id: ad3a28b2c8cdda2573dbd7f9a9fcc9ca73ffc800
wat3rBro
force-pushed
the
export-D42319019
branch
from
054dc8c to
23233fb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42319019 |
wat3rBro
pushed a commit
to wat3rBro/d2go
that referenced
this pull request
Jan 3, 2023
Summary: Pull Request resolved: facebookresearch#453 Differential Revision: D42319019 fbshipit-source-id: 3527fd6e66ffa574daa2f9b5d6e0def4a0448ff8
wat3rBro
force-pushed
the
export-D42319019
branch
from
23233fb to
6538eeb
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42319019 |
wat3rBro
pushed a commit
to wat3rBro/d2go
that referenced
this pull request
Jan 3, 2023
Summary: Pull Request resolved: facebookresearch#453 Differential Revision: D42319019 fbshipit-source-id: dbea1c413f18dec93bde006a6cca2063630ec33e
wat3rBro
force-pushed
the
export-D42319019
branch
from
6538eeb to
a27a543
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42319019 |
wat3rBro
pushed a commit
to wat3rBro/d2go
that referenced
this pull request
Jan 3, 2023
Summary: Pull Request resolved: facebookresearch#453 Differential Revision: D42319019 fbshipit-source-id: cbf65d97dca53008fc6f16f568355141b80533b8
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42319019 |
wat3rBro
force-pushed
the
export-D42319019
branch
from
a27a543 to
bc13bde
Compare
wat3rBro
pushed a commit
to wat3rBro/d2go
that referenced
this pull request
Jan 3, 2023
Summary: Pull Request resolved: facebookresearch#453 Differential Revision: D42319019 fbshipit-source-id: f5476a604ff28672882c272e3fa756690192f2c8
wat3rBro
force-pushed
the
export-D42319019
branch
from
bc13bde to
eab5995
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42319019 |
wat3rBro
pushed a commit
to wat3rBro/d2go
that referenced
this pull request
Jan 4, 2023
Summary: Pull Request resolved: facebookresearch#453 Differential Revision: D42319019 fbshipit-source-id: caf0f42f145e87cc74a23eeb6957140d25b8d056
wat3rBro
force-pushed
the
export-D42319019
branch
from
eab5995 to
1a347a4
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42319019 |
1 similar comment
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42319019 |
wat3rBro
pushed a commit
to wat3rBro/d2go
that referenced
this pull request
Jan 4, 2023
Summary: Pull Request resolved: facebookresearch#453 Differential Revision: D42319019 fbshipit-source-id: b2cad339c2ba05f5e10f6d9939db33e59fbf0803
wat3rBro
force-pushed
the
export-D42319019
branch
from
1a347a4 to
6bdcd9e
Compare
Summary: Pull Request resolved: facebookresearch#453 Previous diffs updated the LRScheduler to public version (eg. facebookresearch/detectron2#4709), this also requires newer version of pytorch-lightning. This diff upgrades the lightning version to 1.8.6, also fixes some deprecated call sites of old lightning versions. - `deepcopy` seems to be supported now, remove `_deepcopy` (there's now not allowed to access `trainer` attributed when it is `None`) - `dataloader_idx` is removed from `on_train_batch_start`. - stop using `_accelerator_connector` (the AcceleratorConnector doesn't have those attributes anymore). - deprecated `on_pretrain_routine_end` -> `on_fit_start` Differential Revision: D42319019 fbshipit-source-id: 3e5da0601e5f3a3fb482c84bb34bdc9f67b0ddfc
wat3rBro
force-pushed
the
export-D42319019
branch
from
6bdcd9e to
8f2b27e
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D42319019 |
Contributor
|
This pull request has been merged in 9e93852. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Differential Revision: D42319019