This repository was archived by the owner on Dec 18, 2023. It is now read-only.
Install a patched version of pytest on CircleCI#477
Closed
horizon-blue wants to merge 1 commit intofacebookresearch:masterfrom
horizon-blue:export-D25480894
Closed
Install a patched version of pytest on CircleCI#477horizon-blue wants to merge 1 commit intofacebookresearch:masterfrom horizon-blue:export-D25480894
horizon-blue wants to merge 1 commit intofacebookresearch:masterfrom
horizon-blue:export-D25480894
Conversation
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25480894 |
2 similar comments
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25480894 |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25480894 |
Summary: Pull Request resolved: #477 As titled. Currently pytest's `import-mode=importlib` option does not add the test file to `sys.module`, which can break some of the use cases. While [the community has came up with a fix](pytest-dev/pytest#7870), it's not yet clear when the particular PR will be merged and added to the latest pytest. So in the meanwhile, we could download and use the patched version by directly from the PR so we are not blocked. Differential Revision: D25480894 fbshipit-source-id: 761b882179d39b7919088a787b6c10e2e03abb77
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D25480894 |
Contributor
|
This pull request has been merged in 14b49f9. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: As titled. Currently pytest's
import-mode=importliboption does not add the test file tosys.module, which can break some of the use cases. While the community has came up with a fix, it's not yet clear when the particular PR will be merged and added to the latest pytest. So in the meanwhile, we could download and use the patched version by directly from the PR so we are not blocked.Differential Revision: D25480894